New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tools: Detect Arm Compiler version using Component #7367

Merged
merged 2 commits into from Jul 3, 2018

Conversation

Projects
None yet
5 participants
@theotherjimmy
Contributor

theotherjimmy commented Jun 28, 2018

Description

In an offline discussion, I found that the arm compiler may spit out:

Product: MDK Professional 5.22
Component: ARM Compiler 5.06 update 6 (build 750)

instead of what I was expecting.

This PR fixes detection logic to use the component field instead of
the product field like I was using before.

Pull request type

[x] Fix
[ ] Refactor
[ ] New target
[ ] Feature
[ ] Breaking change
@theotherjimmy

This comment has been minimized.

Contributor

theotherjimmy commented Jun 28, 2018

@jeromecoutant Could you verify this fix?

@cmonr cmonr requested a review from jeromecoutant Jun 29, 2018

@cmonr

cmonr approved these changes Jun 29, 2018

@cmonr

This comment has been minimized.

Contributor

cmonr commented Jun 29, 2018

LGTM, will hold for @jeromecoutant's Ok.

@jeromecoutant

Hi

Issue fixed.

By the way, before this patch, why the error detection didn't stop test execution?

@theotherjimmy

This comment has been minimized.

Contributor

theotherjimmy commented Jun 29, 2018

@jeromecoutant Thanks for testing!

For the "why not stop" you can see the original PR, #7247

@cmonr

This comment has been minimized.

Contributor

cmonr commented Jun 30, 2018

/morph build

@mbed-ci

This comment has been minimized.

mbed-ci commented Jun 30, 2018

Build : SUCCESS

Build number : 2490
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/7367/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build
/morph mbed2-build

@mbed-ci

This comment has been minimized.

@mbed-ci

This comment has been minimized.

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Jul 2, 2018

/morph export-build

@mbed-ci

This comment has been minimized.

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Jul 2, 2018

/morph export-build

@mbed-ci

This comment has been minimized.

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Jul 2, 2018

/morph export-build

@mbed-ci

This comment has been minimized.

@cmonr cmonr added ready for merge and removed needs: CI labels Jul 3, 2018

@cmonr cmonr merged commit 9c4c630 into ARMmbed:master Jul 3, 2018

14 checks passed

AWS-CI uVisor Build & Test Success
Details
ci-morph-build build completed
Details
ci-morph-exporter build completed
Details
ci-morph-mbed2-build build completed
Details
ci-morph-test test completed
Details
continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
travis-ci/astyle Passed, 913 files
Details
travis-ci/docs Local docs testing has passed
Details
travis-ci/events Passed, runtime is 8940 cycles (-184 cycles)
Details
travis-ci/gitattributestest Local gitattributestest testing has passed
Details
travis-ci/licence_check Local licence_check testing has passed
Details
travis-ci/littlefs Passed, code size is 9964B (+0.00%)
Details
travis-ci/tools-py2.7 Local tools-py2.7 testing has passed
Details

@0xc0170 0xc0170 removed the ready for merge label Jul 3, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment