New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix race condition in serial_api.c for NRF52 series #7369

Merged
merged 2 commits into from Jul 2, 2018

Conversation

Projects
None yet
5 participants
@marcuschangarm
Contributor

marcuschangarm commented Jun 28, 2018

Description

  • Elevate RTC2 interrupt priority to same level as UARTE to prevent race condition on shared variables.
  • Remove unused TXDRDY event code.
  • Fix typo in macro.

Pull request type

[x] Fix
[ ] Refactor
[ ] New target
[ ] Feature
[ ] Breaking change

marcuschangarm added some commits Jun 28, 2018

Fix race condition in serial_api.c for NRF52 series
* Elevate RTC2 interrupt priority to same level as UARTE to prevent
race condition on shared variables.
* Remove unused TXDRDY event code.
* Fix typo in macro.
Fix typo in NRF52 series README.md
UART configuration parameters mispelled.
@marcuschangarm

This comment has been minimized.

Contributor

marcuschangarm commented Jun 28, 2018

@cmonr 😛

@cmonr cmonr requested review from 0xc0170 and kjbracey-arm Jun 29, 2018

@cmonr cmonr added the needs: review label Jun 29, 2018

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Jun 29, 2018

How was this found and shall be tested?

@marcuschangarm

This comment has been minimized.

Contributor

marcuschangarm commented Jun 29, 2018

How was this found and shall be tested?

I'm using the network stress test to download 160 KiB data repeatedly over UART and ESP8266. When testing this PR: #7323 I noticed some new behavior.

@cmonr

This comment has been minimized.

Contributor

cmonr commented Jun 30, 2018

@OPpuolitaival Might be worth looking into @marcuschangarm's test.

/morph build

@mbed-ci

This comment has been minimized.

mbed-ci commented Jun 30, 2018

Build : SUCCESS

Build number : 2488
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/7369/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build
/morph mbed2-build

@mbed-ci

This comment has been minimized.

@mbed-ci

This comment has been minimized.

@0xc0170

0xc0170 approved these changes Jul 2, 2018

@0xc0170 0xc0170 added ready for merge and removed needs: CI labels Jul 2, 2018

@0xc0170 0xc0170 merged commit 44acaf5 into ARMmbed:master Jul 2, 2018

14 checks passed

AWS-CI uVisor Build & Test Success
Details
ci-morph-build build completed
Details
ci-morph-exporter build completed
Details
ci-morph-mbed2-build build completed
Details
ci-morph-test test completed
Details
continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
travis-ci/astyle Passed, 913 files
Details
travis-ci/docs Local docs testing has passed
Details
travis-ci/events Passed, runtime is 9117 cycles (-7 cycles)
Details
travis-ci/gitattributestest Local gitattributestest testing has passed
Details
travis-ci/licence_check Local licence_check testing has passed
Details
travis-ci/littlefs Passed, code size is 9964B (+0.00%)
Details
travis-ci/tools-py2.7 Local tools-py2.7 testing has passed
Details

@0xc0170 0xc0170 removed the ready for merge label Jul 2, 2018

@marcuschangarm marcuschangarm deleted the marcuschangarm:fix-nrf52-serial branch Jul 9, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment