New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cellular: fix greentea tests C027 and BG96 #7374

Merged
merged 1 commit into from Aug 2, 2018

Conversation

Projects
None yet
5 participants
@jarvte
Contributor

jarvte commented Jun 29, 2018

Description

  • Fixed greentea tests for UBLOX C027 and Quectel BG96.
  • SIM test was fixed by adding additional waiting between commands or command might return sim busy
  • Fixed device specific test variations in network and power tests. Fixes to both defects. Some modems don't support command and fixed to take that into account.
  • Power test at timeout was increased as it might take more time than 1s.

No code changes, only test.

Internal ref to defect: IOTCELL-1139
Internal ref to defect: IOTCELL-1140

@mirelachirica please review

Pull request type

[X] Fix
[ ] Refactor
[ ] New target
[ ] Feature
[ ] Breaking change

@0xc0170 0xc0170 requested a review from ARMmbed/mbed-os-wan Jun 29, 2018

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Jun 29, 2018

Internal ref to defect: IOTCELL-1139
Internal ref to defect: IOTCELL-1140

I assume those defects contain info that is not in the commit msg. I expect commit msg state how is this fixing those tests - at least short introduction to the changeset - what is wait(1) fixing and some other changes there.

There are two bugs but one commit fixing both? in two files?

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Jun 29, 2018

Reference https://os.mbed.com/docs/latest/reference/workflow.html - Guidelines for GitHub pull requests

@0xc0170 0xc0170 added the needs: work label Jun 29, 2018

@0xc0170 0xc0170 changed the title from Cellular: fixed greentea tests C027 and BG96. to Cellular: fix greentea tests C027 and BG96 Jul 2, 2018

@cmonr

This comment has been minimized.

Contributor

cmonr commented Jul 5, 2018

@ARMmbed/mbed-os-wan Mind taking a look?

@cmonr

This comment has been minimized.

Contributor

cmonr commented Jul 23, 2018

@cmonr

This comment has been minimized.

Contributor

cmonr commented Jul 30, 2018

Anyone from @ARMmbed/mbed-os-wan in the office?

@jarvte jarvte force-pushed the jarvte:fix_cellular_greentea branch from 88337b6 to 2e62f1b Aug 1, 2018

err = pwr->opt_receive_period(0, CellularPower::EDRXEUTRAN_NB_S1_mode, 3);
TEST_ASSERT(err == NSAPI_ERROR_OK || err == NSAPI_ERROR_DEVICE_ERROR);
if (err == NSAPI_ERROR_DEVICE_ERROR) {
if (!(strcmp(devi, "TELIT_HE910") == 0 || strcmp(devi, "QUECTEL_BG96") == 0)) { // TELIT_HE910 and QUECTEL_BG96 just gives an error and no specific error number so we can't know is this real error or that modem/network does not support the command

This comment has been minimized.

@cmonr

cmonr Aug 1, 2018

Contributor

That's unfortunate.

@cmonr

cmonr approved these changes Aug 1, 2018

@cmonr

This comment has been minimized.

Contributor

cmonr commented Aug 1, 2018

/morph build

@mbed-ci

This comment has been minimized.

mbed-ci commented Aug 1, 2018

Build : SUCCESS

Build number : 2716
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/7374/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build
/morph mbed2-build

@mbed-ci

This comment has been minimized.

@mbed-ci

This comment has been minimized.

@cmonr cmonr added needs: work and removed needs: CI labels Aug 1, 2018

@cmonr

This comment has been minimized.

Contributor

cmonr commented Aug 1, 2018

Looks like tihs needs a rebase.

@jarvte jarvte force-pushed the jarvte:fix_cellular_greentea branch from 2e62f1b to b761e7b Aug 2, 2018

@jarvte

This comment has been minimized.

Contributor

jarvte commented Aug 2, 2018

@cmonr rebase done and tested greentea tests.

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Aug 2, 2018

/morph build

@0xc0170 0xc0170 added needs: CI and removed needs: work labels Aug 2, 2018

@mbed-ci

This comment has been minimized.

mbed-ci commented Aug 2, 2018

Build : SUCCESS

Build number : 2722
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/7374/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build
/morph mbed2-build

@mbed-ci

This comment has been minimized.

@mbed-ci

This comment has been minimized.

@cmonr cmonr added ready for merge and removed needs: CI labels Aug 2, 2018

@cmonr cmonr merged commit 2261ad2 into ARMmbed:master Aug 2, 2018

14 checks passed

AWS-CI uVisor Build & Test Success
Details
ci-morph-build build completed
Details
ci-morph-exporter build completed
Details
ci-morph-mbed2-build build completed
Details
ci-morph-test test completed
Details
continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
travis-ci/astyle Passed, 705 files
Details
travis-ci/docs Local docs testing has passed
Details
travis-ci/events Passed, runtime is 9619 cycles (+669 cycles)
Details
travis-ci/gitattributestest Local gitattributestest testing has passed
Details
travis-ci/licence_check Local licence_check testing has passed
Details
travis-ci/littlefs Passed, code size is 9960B (+0.00%)
Details
travis-ci/tools-py2.7 Local tools-py2.7 testing has passed
Details

@0xc0170 0xc0170 removed the ready for merge label Aug 2, 2018

pan- pushed a commit to pan-/mbed that referenced this pull request Aug 22, 2018

Merge pull request ARMmbed#7374 from jarvte/fix_cellular_greentea
Cellular: fix greentea tests C027 and BG96

@jarvte jarvte deleted the jarvte:fix_cellular_greentea branch Oct 22, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment