New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DISCO_L496AG: change LED1 and LED2 pins #7376

Merged
merged 2 commits into from Jul 5, 2018

Conversation

Projects
None yet
5 participants
@bcostm
Contributor

bcostm commented Jun 29, 2018

Description

Change LED1 and LED2 pins assignments.

Pull request type

[X] Fix
[ ] Refactor
[ ] New target
[ ] Feature
[ ] Breaking change
LED1 = PB_13, // Green LD2 on board
LED2 = LED1,
LED1 = PA_5, // Green LD3 on board
LED2 = PB_13, // Green LD2 on board --> Warning: the state is reverted (1=OFF and 0=ON)

This comment has been minimized.

@jeromecoutant

jeromecoutant Jun 29, 2018

Contributor

Not coherent with PeripheralPins.c:
{PB_13, UART_3, STM_PIN_DATA(STM_MODE_AF_PP, GPIO_PULLUP, GPIO_AF7_USART3)}, // Connected to LED1

This comment has been minimized.

@bcostm

bcostm Jul 2, 2018

Contributor

Forgot the comments in this file. I will update it too. Thanks.

@cmonr cmonr added the needs: work label Jun 30, 2018

@bcostm bcostm force-pushed the bcostm:dev_leds_disco_L496ag branch from 873d3db to b6beb74 Jul 2, 2018

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Jul 2, 2018

@jeromecoutant Please review after the update

@0xc0170 0xc0170 added needs: review and removed needs: work labels Jul 2, 2018

@0xc0170 0xc0170 added needs: CI and removed needs: review labels Jul 2, 2018

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Jul 2, 2018

/morph build

@mbed-ci

This comment has been minimized.

mbed-ci commented Jul 2, 2018

Build : SUCCESS

Build number : 2499
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/7376/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build
/morph mbed2-build

@mbed-ci

This comment has been minimized.

@mbed-ci

This comment has been minimized.

@cmonr

This comment has been minimized.

Contributor

cmonr commented Jul 3, 2018

/morph export-build

@mbed-ci

This comment has been minimized.

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Jul 3, 2018

/morph export-build

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Jul 4, 2018

/morph export-build

@mbed-ci

This comment has been minimized.

@0xc0170

0xc0170 approved these changes Jul 4, 2018

@0xc0170 0xc0170 added ready for merge and removed needs: CI labels Jul 4, 2018

@cmonr cmonr merged commit 1941906 into ARMmbed:master Jul 5, 2018

14 checks passed

AWS-CI uVisor Build & Test Success
Details
ci-morph-build build completed
Details
ci-morph-exporter build completed
Details
ci-morph-mbed2-build build completed
Details
ci-morph-test test completed
Details
continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
travis-ci/astyle Passed, 913 files
Details
travis-ci/docs Local docs testing has passed
Details
travis-ci/events Passed, runtime is 8998 cycles (-1722 cycles)
Details
travis-ci/gitattributestest Local gitattributestest testing has passed
Details
travis-ci/licence_check Local licence_check testing has passed
Details
travis-ci/littlefs Passed, code size is 9964B (+0.00%)
Details
travis-ci/tools-py2.7 Local tools-py2.7 testing has passed
Details

@0xc0170 0xc0170 removed the ready for merge label Jul 5, 2018

@bcostm bcostm deleted the bcostm:dev_leds_disco_L496ag branch Jul 6, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment