New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix memory leakage with MBR on exiting error path #7384

Merged
merged 1 commit into from Jul 3, 2018

Conversation

Projects
None yet
5 participants
@ccli8
Contributor

ccli8 commented Jul 2, 2018

Description

This PR fixes memory leakage on exiting error path in MBRBlockDevice::init.

Pull request type

[X] Fix
[ ] Refactor
[ ] New target
[ ] Feature
[ ] Breaking change

@0xc0170 0xc0170 requested a review from ARMmbed/mbed-os-storage Jul 2, 2018

@0xc0170

0xc0170 approved these changes Jul 2, 2018

@0xc0170 0xc0170 added the needs: CI label Jul 2, 2018

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Jul 2, 2018

/morph build

@mbed-ci

This comment has been minimized.

mbed-ci commented Jul 2, 2018

Build : SUCCESS

Build number : 2491
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/7384/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build
/morph mbed2-build

@mbed-ci

This comment has been minimized.

@mbed-ci

This comment has been minimized.

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Jul 2, 2018

Ci error, restarting

/morph test
/morph export-build

@mbed-ci

This comment has been minimized.

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Jul 2, 2018

/morph build

@0xc0170 0xc0170 closed this Jul 2, 2018

@0xc0170 0xc0170 reopened this Jul 2, 2018

@0xc0170 0xc0170 removed the needs: CI label Jul 2, 2018

@mbed-ci

This comment has been minimized.

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Jul 2, 2018

I accidentally closed this, restarting build, should also re-trigger exporters (pipe closed failure)

@0xc0170 0xc0170 added the needs: CI label Jul 2, 2018

@mbed-ci

This comment has been minimized.

mbed-ci commented Jul 2, 2018

Build : SUCCESS

Build number : 2495
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/7384/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build
/morph mbed2-build

1 similar comment
@mbed-ci

This comment has been minimized.

mbed-ci commented Jul 2, 2018

Build : SUCCESS

Build number : 2495
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/7384/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build
/morph mbed2-build

@mbed-ci

This comment has been minimized.

@mbed-ci

This comment has been minimized.

1 similar comment
@mbed-ci

This comment has been minimized.

@mbed-ci

This comment has been minimized.

@cmonr cmonr merged commit b50f09d into ARMmbed:master Jul 3, 2018

14 checks passed

AWS-CI uVisor Build & Test Success
Details
ci-morph-build build completed
Details
ci-morph-exporter build completed
Details
ci-morph-mbed2-build build completed
Details
ci-morph-test test completed
Details
continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
travis-ci/astyle Passed, 913 files
Details
travis-ci/docs Local docs testing has passed
Details
travis-ci/events Passed, runtime is 9013 cycles (-1707 cycles)
Details
travis-ci/gitattributestest Local gitattributestest testing has passed
Details
travis-ci/licence_check Local licence_check testing has passed
Details
travis-ci/littlefs Passed, code size is 9964B (+0.00%)
Details
travis-ci/tools-py2.7 Local tools-py2.7 testing has passed
Details

@0xc0170 0xc0170 removed the ready for merge label Jul 3, 2018

@ccli8 ccli8 deleted the OpenNuvoton:nuvoton_fix_mbr_memleak branch Jul 23, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment