Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix memory leakage with MBR on exiting error path #7384

Merged
merged 1 commit into from Jul 3, 2018

Conversation

ccli8
Copy link
Contributor

@ccli8 ccli8 commented Jul 2, 2018

Description

This PR fixes memory leakage on exiting error path in MBRBlockDevice::init.

Pull request type

[X] Fix
[ ] Refactor
[ ] New target
[ ] Feature
[ ] Breaking change

@0xc0170 0xc0170 requested a review from a team July 2, 2018 06:30
@0xc0170
Copy link
Contributor

0xc0170 commented Jul 2, 2018

/morph build

@mbed-ci
Copy link

mbed-ci commented Jul 2, 2018

Build : SUCCESS

Build number : 2491
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/7384/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build
/morph mbed2-build

@mbed-ci
Copy link

mbed-ci commented Jul 2, 2018

@mbed-ci
Copy link

mbed-ci commented Jul 2, 2018

@0xc0170
Copy link
Contributor

0xc0170 commented Jul 2, 2018

Ci error, restarting

/morph test
/morph export-build

@mbed-ci
Copy link

mbed-ci commented Jul 2, 2018

@0xc0170
Copy link
Contributor

0xc0170 commented Jul 2, 2018

/morph build

@0xc0170 0xc0170 closed this Jul 2, 2018
@0xc0170 0xc0170 reopened this Jul 2, 2018
@0xc0170 0xc0170 removed the needs: CI label Jul 2, 2018
@mbed-ci
Copy link

mbed-ci commented Jul 2, 2018

@0xc0170
Copy link
Contributor

0xc0170 commented Jul 2, 2018

I accidentally closed this, restarting build, should also re-trigger exporters (pipe closed failure)

@mbed-ci
Copy link

mbed-ci commented Jul 2, 2018

Build : SUCCESS

Build number : 2495
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/7384/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build
/morph mbed2-build

1 similar comment
@mbed-ci
Copy link

mbed-ci commented Jul 2, 2018

Build : SUCCESS

Build number : 2495
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/7384/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build
/morph mbed2-build

@mbed-ci
Copy link

mbed-ci commented Jul 2, 2018

@mbed-ci
Copy link

mbed-ci commented Jul 2, 2018

1 similar comment
@mbed-ci
Copy link

mbed-ci commented Jul 2, 2018

@mbed-ci
Copy link

mbed-ci commented Jul 2, 2018

@cmonr cmonr merged commit b50f09d into ARMmbed:master Jul 3, 2018
@ccli8 ccli8 deleted the nuvoton_fix_mbr_memleak branch July 23, 2018 07:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants