New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug fix for receive windows #7399

Merged
merged 1 commit into from Jul 5, 2018

Conversation

Projects
None yet
6 participants
@hasnainvirk
Contributor

hasnainvirk commented Jul 2, 2018

Description

In rx_config(params) API we shouldn't check for radio state as radio may never get
idle for a class C device. That check made sense only for class A. As the PHY layer
have no conecpt of receive windows which is a MAC layer construct, we should remove the
state check.
The API will be changed later to void rx_config(params).

In addition to that another bug is fixed in the open_rx2_windows() API. We should set the rx slot
first before instantiating a test based on its value.

Pull request type

[X] Fix
[ ] Refactor
[ ] New target
[ ] Feature
[ ] Breaking change
Bug fix for receive windows
In rx_config(params) API we shouldn't check for radio state as radio may never get
idle for a class C device. That check made sense only for class A. As the PHY layer
have no conecpt of receive windows which is a MAC layer construct, we should remove the
state check.
The API will be changed later to void rx_config(params).

In addition to that another bug is fixed in the open_rx2_windows() API. We should set the rx slot
first before instantiating a test based on its value.
@hasnainvirk

This comment has been minimized.

Contributor

hasnainvirk commented Jul 2, 2018

@0xc0170 0xc0170 requested a review from ARMmbed/mbed-os-wan Jul 2, 2018

@0xc0170

0xc0170 approved these changes Jul 3, 2018

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Jul 3, 2018

/morph build

@0xc0170 0xc0170 added needs: CI and removed needs: review labels Jul 3, 2018

@mbed-ci

This comment has been minimized.

mbed-ci commented Jul 3, 2018

Build : SUCCESS

Build number : 2503
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/7399/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build
/morph mbed2-build

@hasnainvirk

This comment has been minimized.

Contributor

hasnainvirk commented Jul 3, 2018

@0xc0170 We will need to redeploy CI for this PR. Aborted for exporter test for some reason.

@mbed-ci

This comment has been minimized.

@hasnainvirk

This comment has been minimized.

Contributor

hasnainvirk commented Jul 3, 2018

@OPpuolitaival Can you please tell me why is the exporter build failing ?

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Jul 3, 2018

/morph export-build

@mbed-ci

This comment has been minimized.

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Jul 4, 2018

/morph export-build

@mbed-ci

This comment has been minimized.

@0xc0170 0xc0170 added ready for merge and removed needs: CI labels Jul 4, 2018

@cmonr cmonr merged commit 87b3fae into ARMmbed:master Jul 5, 2018

14 checks passed

AWS-CI uVisor Build & Test Success
Details
ci-morph-build build completed
Details
ci-morph-exporter build completed
Details
ci-morph-mbed2-build build completed
Details
ci-morph-test test completed
Details
continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
travis-ci/astyle Passed, 790 files
Details
travis-ci/docs Local docs testing has passed
Details
travis-ci/events Passed, runtime is 10161 cycles (+313 cycles)
Details
travis-ci/gitattributestest Local gitattributestest testing has passed
Details
travis-ci/licence_check Local licence_check testing has passed
Details
travis-ci/littlefs Passed, code size is 9964B (+0.00%)
Details
travis-ci/tools-py2.7 Local tools-py2.7 testing has passed
Details

@0xc0170 0xc0170 removed the ready for merge label Jul 5, 2018

@cmonr

This comment has been minimized.

Contributor

cmonr commented Jul 16, 2018

The use of _lora_phy.handle_receive(); is throwing this to 5.10.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment