New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix target definition for NRF52 series #7405

Merged
merged 1 commit into from Jul 5, 2018

Conversation

Projects
None yet
5 participants
@marcuschangarm
Contributor

marcuschangarm commented Jul 3, 2018

Description

  • Removed RTC, NRF52840 doesn't support RTC API.
  • Reorganized DEVICE_HAS order for NRF52832.

Pull request type

[x] Fix
[ ] Refactor
[ ] New target
[ ] Feature
[ ] Breaking change
Fix target definition for NRF52 series
 * Removed RTC, NRF52840 doesn't support RTC API.
 * Reorganized DEVICE_HAS order for NRF52832.

@cmonr cmonr requested review from pan- and donatieng Jul 3, 2018

@cmonr cmonr added the needs: review label Jul 3, 2018

@0xc0170

0xc0170 approved these changes Jul 3, 2018

How come RTC did not error if it was not supported? fallback to lp ticker?

@marcuschangarm

This comment has been minimized.

Contributor

marcuschangarm commented Jul 3, 2018

How come RTC did not error if it was not supported? fallback to lp ticker?

The NRF52840_DK is not part of CI testing.

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Jul 4, 2018

/morph build

@mbed-ci

This comment has been minimized.

mbed-ci commented Jul 4, 2018

Build : SUCCESS

Build number : 2525
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/7405/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build
/morph mbed2-build

@mbed-ci

This comment has been minimized.

@mbed-ci

This comment has been minimized.

@cmonr cmonr merged commit 917dc83 into ARMmbed:master Jul 5, 2018

14 checks passed

AWS-CI uVisor Build & Test Success
Details
ci-morph-build build completed
Details
ci-morph-exporter build completed
Details
ci-morph-mbed2-build build completed
Details
ci-morph-test test completed
Details
continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
travis-ci/astyle Passed, 791 files
Details
travis-ci/docs Local docs testing has passed
Details
travis-ci/events Passed, runtime is 9073 cycles (-1142 cycles)
Details
travis-ci/gitattributestest Local gitattributestest testing has passed
Details
travis-ci/licence_check Local licence_check testing has passed
Details
travis-ci/littlefs Passed, code size is 9964B (+0.00%)
Details
travis-ci/tools-py2.7 Local tools-py2.7 testing has passed
Details

@0xc0170 0xc0170 removed the ready for merge label Jul 5, 2018

@marcuschangarm marcuschangarm deleted the marcuschangarm:fix-nrf52-target branch Jul 9, 2018

@loverdeg-ep

This comment has been minimized.

loverdeg-ep commented Jul 13, 2018

@marcuschangarm

The NRF52840_DK is not part of CI testing.

What is the holdup on making the 'PDK' Mbed official?
We still are having issues using daplink with it since it's not technically supported.

@marcuschangarm

This comment has been minimized.

Contributor

marcuschangarm commented Jul 13, 2018

@cmonr

This comment has been minimized.

Contributor

cmonr commented Jul 13, 2018

@loverdeg-ep Fyi, I would suggest y'all create an issue since coments that appears on closed PRs receive little attention.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment