New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NANO130: Change PLL clock source to HIRC instead of HXT #7406
Conversation
This change is to reduce delay of wake-up from power-down to pass Greentea test. Because HIRC's accuracy is worse than HXT's, we must switch back to HXT for e.g. USBD application. This can be done through setting NU_CLOCK_PLL to NU_HXT_PLL.
* it will go T1 with HXT already enabled in front. So we manually configure | ||
* it to choose HXT/HIRC-clocked PLL. | ||
*/ | ||
#define NU_HXT_PLL 1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
would this be better in the target configuration that hardcoded here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@0xc0170 Do you mean below? They must be defined in source code, so that they can be chosen from in targets.json
or mbed_app.json
.
#define NU_HXT_PLL 1
#define NU_HIRC_PLL 2
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I did not spot the target json edit here previously, LGTM
/morph build |
Build : FAILUREBuild number : 2506 |
/morph build |
Build : SUCCESSBuild number : 2545 Triggering tests/morph test |
Exporter Build : SUCCESSBuild number : 2189 |
Test : SUCCESSBuild number : 2300 |
…elay NANO130: Change PLL clock source to HIRC instead of HXT
Description
This PR is to reduce delay of wake-up from power-down to pass Greentea test (require 10ms) by changing PLL clock source to HIRC from HXT. Because HIRC's accuracy is worse than HXT's, we must switch back to HXT for e.g. USBD application. This can be done through setting NU_CLOCK_PLL to NU_HXT_PLL.
Pull request type