Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NANO130: Change PLL clock source to HIRC instead of HXT #7406

Merged
merged 1 commit into from Jul 6, 2018

Conversation

ccli8
Copy link
Contributor

@ccli8 ccli8 commented Jul 3, 2018

Description

This PR is to reduce delay of wake-up from power-down to pass Greentea test (require 10ms) by changing PLL clock source to HIRC from HXT. Because HIRC's accuracy is worse than HXT's, we must switch back to HXT for e.g. USBD application. This can be done through setting NU_CLOCK_PLL to NU_HXT_PLL.

Pull request type

[X] Fix
[ ] Refactor
[ ] New target
[ ] Feature
[ ] Breaking change

This change is to reduce delay of wake-up from power-down to pass Greentea test.
Because HIRC's accuracy is worse than HXT's, we must switch back to HXT for e.g. USBD application.
This can be done through setting NU_CLOCK_PLL to NU_HXT_PLL.
* it will go T1 with HXT already enabled in front. So we manually configure
* it to choose HXT/HIRC-clocked PLL.
*/
#define NU_HXT_PLL 1
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

would this be better in the target configuration that hardcoded here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@0xc0170 Do you mean below? They must be defined in source code, so that they can be chosen from in targets.json or mbed_app.json.

#define NU_HXT_PLL  1
#define NU_HIRC_PLL 2

Copy link
Contributor

@0xc0170 0xc0170 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did not spot the target json edit here previously, LGTM

@0xc0170
Copy link
Contributor

0xc0170 commented Jul 3, 2018

/morph build

@mbed-ci
Copy link

mbed-ci commented Jul 3, 2018

Build : FAILURE

Build number : 2506
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/7406/

@cmonr
Copy link
Contributor

cmonr commented Jul 5, 2018

/morph build

@mbed-ci
Copy link

mbed-ci commented Jul 6, 2018

Build : SUCCESS

Build number : 2545
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/7406/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build
/morph mbed2-build

@mbed-ci
Copy link

mbed-ci commented Jul 6, 2018

@mbed-ci
Copy link

mbed-ci commented Jul 6, 2018

@cmonr cmonr merged commit 59defa2 into ARMmbed:master Jul 6, 2018
@ccli8 ccli8 deleted the nuvoton_fix_wakeup_delay branch July 9, 2018 01:06
pan- pushed a commit to pan-/mbed that referenced this pull request Aug 22, 2018
…elay

NANO130: Change PLL clock source to HIRC instead of HXT
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants