New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modified Wiced drivers EMAC instance get #7413

Merged
merged 1 commit into from Jul 5, 2018

Conversation

Projects
None yet
6 participants
@mikaleppanen
Contributor

mikaleppanen commented Jul 4, 2018

Description

Removed EMAC get_default_instance() since WLAN drivers are not default EMAC drivers. Moved EMAC static declaration inside get_instance().

Changes has been tested using ip-core nightly Jenkins jobs.

Fixes #7372

Pull request type

[X] Fix
[ ] Refactor
[ ] New target
[ ] Feature
[ ] Breaking change
Modified Wiced drivers EMAC instance get
Removed EMAC get_default_instance() since WLAN drivers are not default EMAC drivers.
Moved EMAC static declaration inside get_instance().
@0xc0170

This comment has been minimized.

Member

0xc0170 commented Jul 4, 2018

cc @pan

@0xc0170

0xc0170 approved these changes Jul 4, 2018

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Jul 4, 2018

/morph build

@0xc0170 0xc0170 requested a review from KariHaapalehto Jul 4, 2018

@mikaleppanen

This comment has been minimized.

Contributor

mikaleppanen commented Jul 4, 2018

@0xc0170 Kari is on vacation. @kjbracey-arm Please review this.

@0xc0170 0xc0170 added needs: CI and removed needs: review labels Jul 4, 2018

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Jul 4, 2018

/morph build

@mbed-ci

This comment has been minimized.

mbed-ci commented Jul 4, 2018

Build : SUCCESS

Build number : 2523
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/7413/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build
/morph mbed2-build

@pan-

pan- approved these changes Jul 4, 2018

That is more bearable.

+------------------+-------+-------+------+
| Module           | .text | .data | .bss |
+------------------+-------+-------+------+
| [fill]           |   100 |     4 |   21 |
| [lib]\c.a        | 25093 |  2472 |   89 |
| [lib]\gcc.a      |  3168 |     0 |    0 |
| [lib]\misc       |   252 |    16 |   28 |
| main.o           |    31 |     0 |    0 |
| mbed-os\drivers  |   192 |     4 |  100 |
| mbed-os\features |   204 |    12 |   48 |
| mbed-os\hal      |  1653 |     4 |   68 |
| mbed-os\platform |  2764 |   260 |  133 |
| mbed-os\rtos     |  9337 |   168 | 6073 |
| mbed-os\targets  |  7328 |     4 |  428 |
| Subtotals        | 50122 |  2944 | 6988 |
+------------------+-------+-------+------+
@mbed-ci

This comment has been minimized.

mbed-ci commented Jul 4, 2018

Build : SUCCESS

Build number : 2527
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/7413/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build
/morph mbed2-build

@mbed-ci

This comment has been minimized.

@mbed-ci

This comment has been minimized.

@0xc0170 0xc0170 added ready for merge and removed needs: CI labels Jul 4, 2018

@mbed-ci

This comment has been minimized.

@mbed-ci

This comment has been minimized.

@cmonr cmonr merged commit 4942ec5 into ARMmbed:master Jul 5, 2018

14 checks passed

AWS-CI uVisor Build & Test Success
Details
ci-morph-build build completed
Details
ci-morph-exporter build completed
Details
ci-morph-mbed2-build build completed
Details
ci-morph-test test completed
Details
continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
travis-ci/astyle Passed, 791 files
Details
travis-ci/docs Local docs testing has passed
Details
travis-ci/events Passed, runtime is 9613 cycles (-602 cycles)
Details
travis-ci/gitattributestest Local gitattributestest testing has passed
Details
travis-ci/licence_check Local licence_check testing has passed
Details
travis-ci/littlefs Passed, code size is 9964B (+0.00%)
Details
travis-ci/tools-py2.7 Local tools-py2.7 testing has passed
Details

@0xc0170 0xc0170 removed the ready for merge label Jul 5, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment