New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lora: Add support for runtime PHY selection #7430

Merged
merged 2 commits into from Jul 11, 2018

Conversation

Projects
None yet
6 participants
@kivaisan
Contributor

kivaisan commented Jul 6, 2018

Description

Add support to set up lora stack using user given PHY object. This will enable PHY selection at run time (usefull for example to roaming devices).

Pull request type

[ ] Fix
[ ] Refactor
[ ] New target
[X] Feature
[ ] Breaking change
Lora: Add initialize() method to set LoRaWANTimeHandler class for phy
Instead of giving LoRaWANTimeHandler object as parameter for constructor,
object is now given via own initialize() method.

This change is needed for future refactoring where application can give own
PHY object for LoRa stack.
@kivaisan

This comment has been minimized.

Contributor

kivaisan commented Jul 6, 2018

@hasnainvirk, @kjbracey-arm, please review.

*
*/
void bind_radio_driver(LoRaRadio &radio);
void bind_phy_and_radio_driver(LoRaRadio& radio, LoRaPHY &phy);

This comment has been minimized.

@hasnainvirk

hasnainvirk Jul 6, 2018

Contributor

LoRaRadio& radio -> LoRaRadio &radio

* @param phy A reference to user created PHY object.
*
*/
LoRaWANInterface(LoRaRadio& radio, LoRaPHY &phy);

This comment has been minimized.

@hasnainvirk

hasnainvirk Jul 6, 2018

Contributor

Add doc for the first parameter as well.

@kivaisan kivaisan force-pushed the kivaisan:user_constructed_phy_v2 branch 2 times, most recently from 0ee2271 to 014ff22 Jul 6, 2018

@kivaisan

This comment has been minimized.

Contributor

kivaisan commented Jul 6, 2018

@hasnainvirk please review again.

* @param radio A reference to radio object
* @param phy A reference to PHY object
*/
LoRaWANInterface(LoRaRadio& radio, LoRaPHY &phy);

This comment has been minimized.

@hasnainvirk

hasnainvirk Jul 6, 2018

Contributor

Style fix here. LoRaRadio& radio -> LoRaRadio &radio

@@ -98,15 +98,16 @@ LoRaWANStack::LoRaWANStack()
/*****************************************************************************
* Public Methods *
****************************************************************************/
void LoRaWANStack::bind_radio_driver(LoRaRadio &radio)
void LoRaWANStack::bind_phy_and_radio_driver(LoRaRadio& radio, LoRaPHY &phy)

This comment has been minimized.

@hasnainvirk

hasnainvirk Jul 6, 2018

Contributor

Style fix here. LoRaRadio &raido

*
*/
void bind_radio_driver(LoRaRadio &radio);
void bind_phy_and_radio_driver(LoRaRadio &radio, LoRaPHY &phy);

This comment has been minimized.

@hasnainvirk

hasnainvirk Jul 6, 2018

Contributor

Style fix LoRaRadio &radio

This comment has been minimized.

@kivaisan

kivaisan Jul 6, 2018

Contributor

This one is good already but I fixed some other radio style bugs.

@kivaisan kivaisan force-pushed the kivaisan:user_constructed_phy_v2 branch from 014ff22 to 2b6da95 Jul 6, 2018

Lora: Support user provided LoRaPHY object
To support custom PHY object, a new LoRaWANInterface constructor was
added.

@kivaisan kivaisan force-pushed the kivaisan:user_constructed_phy_v2 branch from 2b6da95 to 0397b0b Jul 6, 2018

@cmonr cmonr added the needs: review label Jul 6, 2018

@hasnainvirk

This comment has been minimized.

Contributor

hasnainvirk commented Jul 9, 2018

@kjbracey-arm Can you please spare some time to review this ?

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Jul 9, 2018

/morph build

@mbed-ci

This comment has been minimized.

mbed-ci commented Jul 9, 2018

Build : SUCCESS

Build number : 2551
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/7430/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build
/morph mbed2-build

@mbed-ci

This comment has been minimized.

@mbed-ci

This comment has been minimized.

@cmonr cmonr added ready for merge and removed needs: review labels Jul 11, 2018

@cmonr

This comment has been minimized.

Contributor

cmonr commented Jul 11, 2018

Looks good to go!

@cmonr cmonr merged commit 3f742c9 into ARMmbed:master Jul 11, 2018

14 checks passed

AWS-CI uVisor Build & Test Success
Details
ci-morph-build build completed
Details
ci-morph-exporter build completed
Details
ci-morph-mbed2-build build completed
Details
ci-morph-test test completed
Details
continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
travis-ci/astyle Passed, 791 files
Details
travis-ci/docs Local docs testing has passed
Details
travis-ci/events Passed, runtime is 8963 cycles (-593 cycles)
Details
travis-ci/gitattributestest Local gitattributestest testing has passed
Details
travis-ci/licence_check Local licence_check testing has passed
Details
travis-ci/littlefs Passed, code size is 9964B (+0.00%)
Details
travis-ci/tools-py2.7 Local tools-py2.7 testing has passed
Details

pan- pushed a commit to pan-/mbed that referenced this pull request Aug 22, 2018

Merge pull request ARMmbed#7430 from kivaisan/user_constructed_phy_v2
Lora: Add support for runtime PHY selection
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment