New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recognize ".cc" and ".hh" source file extensions #7437

Merged
merged 1 commit into from Jul 10, 2018

Conversation

Projects
None yet
6 participants
@snej
Contributor

snej commented Jul 6, 2018

Description

Minor change to the Python mbedToolchain class to recognize the commonly used filename extensions ".cc" (C++ source code) and ".hh" (C++ header). Without this change, source code with this naming convention (e.g. my company's entire sourcebase) is ignored by the CLI.

Tested by building a project containing source code with such filename suffixes.

Pull request type

[x] Fix
[ ] Refactor
[ ] New target
[ ] Feature
[ ] Breaking change
Recognize ".cc" and ".hh" source file extensions
".cc" --> C++ source code
".hh" --> header

This change allows existing source code with this naming
convention (e.g. my company's) to be used in mbed.os projects.

@0xc0170 0xc0170 requested a review from ARMmbed/mbed-os-tools Jul 9, 2018

@cmonr

cmonr approved these changes Jul 9, 2018

LGTM

@cmonr

This comment has been minimized.

Contributor

cmonr commented Jul 9, 2018

@theotherjimmy Any objections?

@theotherjimmy

theotherjimmy approved these changes Jul 9, 2018 edited

I'll have to rebase my refactor-resources pr when this goes in, or you'll have to rebase this.

@cmonr

This comment has been minimized.

Contributor

cmonr commented Jul 9, 2018

/morph build

@mbed-ci

This comment has been minimized.

mbed-ci commented Jul 9, 2018

Build : SUCCESS

Build number : 2553
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/7437/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build
/morph mbed2-build

@mbed-ci

This comment has been minimized.

@mbed-ci

This comment has been minimized.

@cmonr

This comment has been minimized.

Contributor

cmonr commented Jul 10, 2018

/morph mbed2-build

@0xc0170 0xc0170 added ready for merge and removed needs: CI labels Jul 10, 2018

@0xc0170 0xc0170 merged commit 61f3d8b into ARMmbed:master Jul 10, 2018

14 checks passed

AWS-CI uVisor Build & Test Success
Details
ci-morph-build build completed
Details
ci-morph-exporter build completed
Details
ci-morph-mbed2-build build completed
Details
ci-morph-test test completed
Details
continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
travis-ci/astyle Passed, 791 files
Details
travis-ci/docs Local docs testing has passed
Details
travis-ci/events Passed, runtime is 9603 cycles (-18 cycles)
Details
travis-ci/gitattributestest Local gitattributestest testing has passed
Details
travis-ci/licence_check Local licence_check testing has passed
Details
travis-ci/littlefs Passed, code size is 9960B (+0.00%)
Details
travis-ci/tools-py2.7 Local tools-py2.7 testing has passed
Details
@0xc0170

This comment has been minimized.

Member

0xc0170 commented Jul 10, 2018

@snej Thanks for the contribution

pan- pushed a commit to pan-/mbed that referenced this pull request Aug 22, 2018

Merge pull request ARMmbed#7437 from snej/master
Recognize ".cc" and ".hh" source file extensions
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment