New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix SWI conflict in SoftDevice for NRF52 series #7453

Merged
merged 3 commits into from Jul 11, 2018

Conversation

Projects
None yet
6 participants
@marcuschangarm
Contributor

marcuschangarm commented Jul 9, 2018

Description

SWI channels reserved for the SoftDevice were incorrectly defined leading to conflicts in the serial implementation. New serial driver only uses one SWI channel instead of four.

Pull request type

[x] Fix
[ ] Refactor
[ ] New target
[ ] Feature
[ ] Breaking change

marcuschangarm added some commits Jul 9, 2018

Fix inconsistent SWI configuration in NRF52 series
All SWI channels except SWI0 is being used by the SoftDevice and
not only SWI1.
Change NRF52 series UART to only use one SWI channel
This fixes conflicts with the SoftDevice.
@0xc0170

This comment has been minimized.

Member

0xc0170 commented Jul 10, 2018

At least one user confirmed that this fixes the issue

/morph build

@mbed-ci

This comment has been minimized.

mbed-ci commented Jul 10, 2018

Build : SUCCESS

Build number : 2555
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/7453/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build
/morph mbed2-build

@NeilMacMullen

This comment has been minimized.

NeilMacMullen commented Jul 10, 2018

This seems to address the issue I was seeing in #7219 (comment) so is a significant improvement.

However, there still appears to be an issue with SPI. I'm still trying to pin this down but it appears that on one of the spi buses I am using, it's not possible to read data.

@mbed-ci

This comment has been minimized.

@marcuschangarm

This comment has been minimized.

Contributor

marcuschangarm commented Jul 10, 2018

@NeilMacMullen

However, there still appears to be an issue with SPI. I'm still trying to pin this down but it appears that on one of the spi buses I am using, it's not possible to read data.

Is this a new issue or do you have an open github issue for it?

@NeilMacMullen

This comment has been minimized.

NeilMacMullen commented Jul 10, 2018

@marcuschangarm It's 'new' in the sense that I only discovered it after overcoming the initial problems and it doesn't currently have its own issue id. I don't think it was caused by this fix and may have been present on master for some time, I only mentioned it here in case some variation of this fix might be relevant to SPI as well. Probably best if I raise a separate ticket for it.

@marcuschangarm

This comment has been minimized.

Contributor

marcuschangarm commented Jul 10, 2018

I only mentioned it here in case some variation of this fix might be relevant to SPI as well.

I don't recall any direct dependencies between SPI and UART/BLE.

@cmonr

This comment has been minimized.

Contributor

cmonr commented Jul 11, 2018

/morph export-build

@cmonr cmonr added needs: CI and removed needs: review labels Jul 11, 2018

@mbed-ci

This comment has been minimized.

@cmonr

This comment has been minimized.

Contributor

cmonr commented Jul 11, 2018

@NeilMacMullen If there isn't already an issue open, please go ahead and open one. We can track problems better when they're in a GitHub issues instead of comments in PRs.

Bringing this in since the PR appears to address its initial problem scope.

@cmonr cmonr merged commit 38c5e9c into ARMmbed:master Jul 11, 2018

14 checks passed

AWS-CI uVisor Build & Test Success
Details
ci-morph-build build completed
Details
ci-morph-exporter build completed
Details
ci-morph-mbed2-build build completed
Details
ci-morph-test test completed
Details
continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
travis-ci/astyle Passed, 791 files
Details
travis-ci/docs Local docs testing has passed
Details
travis-ci/events Passed, runtime is 9623 cycles (-538 cycles)
Details
travis-ci/gitattributestest Local gitattributestest testing has passed
Details
travis-ci/licence_check Local licence_check testing has passed
Details
travis-ci/littlefs Passed, code size is 9960B (+0.00%)
Details
travis-ci/tools-py2.7 Local tools-py2.7 testing has passed
Details
@AGlass0fMilk

This comment has been minimized.

Contributor

AGlass0fMilk commented Jul 12, 2018

Resolves #7440

pan- pushed a commit to pan-/mbed that referenced this pull request Aug 22, 2018

Merge pull request ARMmbed#7453 from marcuschangarm/fix-nrf52-swi
Fix SWI conflict in SoftDevice for NRF52 series
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment