New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Raytac: target removal #7461

Merged
merged 1 commit into from Jul 13, 2018

Conversation

Projects
None yet
4 participants
@0xc0170
Member

0xc0170 commented Jul 10, 2018

No files to build - should not be in targets
Reverts part of the #6178

This target should not be defined in targets (no files related in the codebase).

@andrewleech

Description

Pull request type

[X] Fix
[ ] Refactor
[ ] New target
[ ] Feature
[ ] Breaking change
Raytac: target removal
No files to build - should not be in targets
Reverts part of the #6178
@0xc0170

This comment has been minimized.

Member

0xc0170 commented Jul 10, 2018

Fixes #7460

@cmonr

cmonr approved these changes Jul 10, 2018

@cmonr

This comment has been minimized.

Contributor

cmonr commented Jul 10, 2018

Will start CI once @andrewleech has ack'd.

@cmonr

This comment has been minimized.

Contributor

cmonr commented Jul 12, 2018

/morph build

@cmonr

This comment has been minimized.

Contributor

cmonr commented Jul 12, 2018

Started CI since another PR is waiting on this to come in.

@andrewleech Feel free to still confirm.

@cmonr cmonr added needs: CI and removed needs: review labels Jul 12, 2018

@mbed-ci

This comment has been minimized.

mbed-ci commented Jul 12, 2018

Build : SUCCESS

Build number : 2592
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/7461/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build
/morph mbed2-build

@andrewleech

This comment has been minimized.

Contributor

andrewleech commented Jul 12, 2018

Hi,
Sorry I thought I had added the files needed for this target to build by itself, clearly I hadn't done enough.

I'm fine with it being removed, if I see a need in future I'll open a new PR with some better testing on my end to add all the needed files.

fyi In our project this was actually an intermediate target defining the common stuff for the off-the-shelf module and I had a second target in my custom_targets file with the pinouts etc of the custom pcb the module was mounted on.

@mbed-ci

This comment has been minimized.

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Jul 13, 2018

Thanks @andrewleech for the info. Once test passes, will be ready to go in.

@mbed-ci

This comment has been minimized.

@cmonr cmonr merged commit 531ee3c into ARMmbed:master Jul 13, 2018

14 checks passed

AWS-CI uVisor Build & Test Success
Details
ci-morph-build build completed
Details
ci-morph-exporter build completed
Details
ci-morph-mbed2-build build completed
Details
ci-morph-test test completed
Details
continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
travis-ci/astyle Passed, 791 files
Details
travis-ci/docs Local docs testing has passed
Details
travis-ci/events Passed, runtime is 9582 cycles (-579 cycles)
Details
travis-ci/gitattributestest Local gitattributestest testing has passed
Details
travis-ci/licence_check Local licence_check testing has passed
Details
travis-ci/littlefs Passed, code size is 9960B (+0.00%)
Details
travis-ci/tools-py2.7 Local tools-py2.7 testing has passed
Details

pan- pushed a commit to pan-/mbed that referenced this pull request Aug 22, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment