New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tools: py3 compatible mbed-os version lowercasing #7475

Merged
merged 1 commit into from Jul 14, 2018

Conversation

Projects
None yet
4 participants
@theotherjimmy
Contributor

theotherjimmy commented Jul 11, 2018

Description

There's version lowercasing going on in the tools to do some checks
and it was not python 3 compatible. I fixed it.

Pull request type

[x] Fix
[ ] Refactor
[ ] New target
[ ] Feature
[ ] Breaking change

@theotherjimmy theotherjimmy force-pushed the theotherjimmy:py3-release-ver-parse branch from ac90fe5 to 6d42bd3 Jul 11, 2018

try:
return release_version.lower()
except AttributeError:
return 'all'

This comment has been minimized.

@cmonr

cmonr Jul 11, 2018

Contributor

Return 'all'?
Will this result in only printing the version warning if run with Py2?

This comment has been minimized.

@theotherjimmy
@cmonr

cmonr approved these changes Jul 13, 2018

@cmonr

This comment has been minimized.

Contributor

cmonr commented Jul 13, 2018

/morph build

@cmonr cmonr added needs: CI and removed needs: review labels Jul 13, 2018

@mbed-ci

This comment has been minimized.

mbed-ci commented Jul 13, 2018

Build : SUCCESS

Build number : 2602
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/7475/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build
/morph mbed2-build

@mbed-ci

This comment has been minimized.

@mbed-ci

This comment has been minimized.

@cmonr cmonr merged commit 39407ad into ARMmbed:master Jul 14, 2018

14 checks passed

AWS-CI uVisor Build & Test Success
Details
ci-morph-build build completed
Details
ci-morph-exporter build completed
Details
ci-morph-mbed2-build build completed
Details
ci-morph-test test completed
Details
continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
travis-ci/astyle Passed, 791 files
Details
travis-ci/docs Local docs testing has passed
Details
travis-ci/events Passed, runtime is 9988 cycles (+386 cycles)
Details
travis-ci/gitattributestest Local gitattributestest testing has passed
Details
travis-ci/licence_check Local licence_check testing has passed
Details
travis-ci/littlefs Passed, code size is 9960B (+0.00%)
Details
travis-ci/tools-py2.7 Local tools-py2.7 testing has passed
Details

@0xc0170 0xc0170 removed the needs: CI label Jul 14, 2018

pan- pushed a commit to pan-/mbed that referenced this pull request Aug 22, 2018

Merge pull request ARMmbed#7475 from theotherjimmy/py3-release-ver-parse
Tools: py3 compatible mbed-os version lowercasing
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment