New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

STM32: Improve GPIO IRQ edge detection when waking from deepsleep #7510

Merged
merged 1 commit into from Jul 23, 2018

Conversation

Projects
None yet
7 participants
@mattbrown015
Contributor

mattbrown015 commented Jul 13, 2018

Description

Resolves STM32L4: Incorrect GPIO Interrupts When Using MBED_TICKLESS #7493

After defining MBED_TICKLESS my InterruptIn fall handler stopped being called.

It appears that handle_interrupt_in was incorrectly deciding that a rising edge had caused the IRQ and was attempting the to call the non-existent rise handler. Hence I missed the IRQ.

This problem is something to do with transition from deepsleep, aka stop mode 2, and didn't occur when MBED_TICKLESS was undefined.

Pull request type

[X] Fix
[ ] Refactor
[ ] New target
[ ] Feature
[ ] Breaking change
@LMESTM

LMESTM approved these changes Jul 13, 2018

Looks good to me !

@LMESTM

This comment has been minimized.

Contributor

LMESTM commented Jul 13, 2018

@mattbrown015 thanks for your contribution !
Needs to be tested to check it works well on all families of STM32.
@jeromecoutant should be able to help next week :-)

@cmonr cmonr requested a review from jeromecoutant Jul 13, 2018

@cmonr cmonr added the needs: review label Jul 13, 2018

@jeromecoutant

This comment has been minimized.

Contributor

jeromecoutant commented Jul 16, 2018

@jeromecoutant should be able to help next week :-)

It has been done during the week end !

I ran tests over all STM32 families => OK
CI shield tests also with all families => OK

@bcostm

bcostm approved these changes Jul 16, 2018

Thanks for this fix

@0xc0170 0xc0170 added needs: CI and removed needs: review labels Jul 17, 2018

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Jul 17, 2018

/morph build

@mbed-ci

This comment has been minimized.

mbed-ci commented Jul 17, 2018

@cmonr cmonr added needs: work and removed needs: CI labels Jul 18, 2018

@jeromecoutant

This comment has been minimized.

Contributor

jeromecoutant commented Jul 18, 2018

Hi
I understoood the build issue, patch is on going

@jeromecoutant

This comment has been minimized.

Contributor

jeromecoutant commented Jul 18, 2018

Hi
Please merge #7539 before this one.

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Jul 20, 2018

Please merge #7539 before this one.

Merged. @mattbrown015 Can you rebase from latest master to get the dependency in

@jeromecoutant

This comment has been minimized.

Contributor

jeromecoutant commented Jul 20, 2018

Can you rebase from latest master

I don't think some rebase is needed

/morph build

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Jul 20, 2018

I don't think some rebase is needed

OK. It was not clear how it depends on the other pull request.

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Jul 20, 2018

Please review logs http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/7510/ - failures in linking - functions definitions are missing?

@jeromecoutant

This comment has been minimized.

Contributor

jeromecoutant commented Jul 20, 2018

Yes, the correct include has been added in #7539

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Jul 20, 2018

/morph build

@0xc0170 0xc0170 added needs: CI and removed needs: work labels Jul 20, 2018

@mbed-ci

This comment has been minimized.

mbed-ci commented Jul 20, 2018

Build : SUCCESS

Build number : 2653
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/7510/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build
/morph mbed2-build

@mbed-ci

This comment has been minimized.

@mbed-ci

This comment has been minimized.

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Jul 23, 2018

/morph mbed2-build

@0xc0170 0xc0170 added ready for merge and removed needs: CI labels Jul 23, 2018

@cmonr cmonr merged commit 21dbbc5 into ARMmbed:master Jul 23, 2018

14 checks passed

AWS-CI uVisor Build & Test Success
Details
ci-morph-build build completed
Details
ci-morph-exporter build completed
Details
ci-morph-mbed2-build build completed
Details
ci-morph-test test completed
Details
continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
travis-ci/astyle Passed, 791 files
Details
travis-ci/docs Local docs testing has passed
Details
travis-ci/events Passed, runtime is 10775 cycles (+1863 cycles)
Details
travis-ci/gitattributestest Local gitattributestest testing has passed
Details
travis-ci/licence_check Local licence_check testing has passed
Details
travis-ci/littlefs Passed, code size is 9960B (+0.00%)
Details
travis-ci/tools-py2.7 Local tools-py2.7 testing has passed
Details

pan- pushed a commit to pan-/mbed that referenced this pull request Aug 22, 2018

Merge pull request ARMmbed#7510 from mattbrown015/fix_stm32_gpio_irq_…
…deepsleep

STM32: Improve GPIO IRQ edge detection when waking from deepsleep
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment