New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RTOS SYSTIMER test error in TICKLESS mode #7530

Merged
merged 1 commit into from Jul 23, 2018

Conversation

Projects
None yet
5 participants
@jeromecoutant
Contributor

jeromecoutant commented Jul 17, 2018

Description

If we enable MBED_TICKLESS, we got a compilation error:

    [DEBUG] Output: ".\TESTS\mbedmicro-rtos-mbed\systimer\main.cpp", line 16: Error:  #29: expected an expression

Pull request type

[x] Fix
[ ] Refactor
[ ] New target
[ ] Feature
[ ] Breaking change

@jeromecoutant jeromecoutant changed the title from RTOS SYSTIMER test error to RTOS SYSTIMER test error in TICKLESS mode Jul 17, 2018

@0xc0170 0xc0170 requested a review from fkjagodzinski Jul 17, 2018

@fkjagodzinski

Please provide more info in the commit message. Is this specific to one compiler, if so which one? I checked with GCC_ARM and this patch does not change anything.

@0xc0170 0xc0170 added needs: work and removed needs: review labels Jul 17, 2018

@jeromecoutant

This comment has been minimized.

Contributor

jeromecoutant commented Jul 19, 2018

Hi

If we add "MBED_TICKLESS" in the macro in targets.json file,
there is no compilation issue!

If we add "MBED_TICKLESS" in the macro in mbed_app.json file,
we got the compilation issues with all compilers:

  • mbed test -t ARM -m NUCLEO_F429ZI -v -n tests-*systimer --compile
    [DEBUG] Output: ".\TESTS\mbedmicro-rtos-mbed\systimer\main.cpp", line 16: Error: #29: expected an expression

  • mbed test -t GCC_ARM -m NUCLEO_F429ZI -v -n tests-*systimer --compile
    [DEBUG] Output: .\TESTS\mbedmicro-rtos-mbed\systimer\main.cpp:16:19: error: operator '!' has no right operand
    [DEBUG] Output: #if !MBED_TICKLESS

  • mbed test -t IAR -m NUCLEO_F429ZI -v -n tests-*systimer --compile
    [DEBUG] Output: #if !MBED_TICKLESS
    [DEBUG] Output: "C:\github\mbed\TESTS\mbedmicro-rtos-mbed\systimer\main.cpp",16 Error[Pe029]: expected an expression

@fkjagodzinski

This comment has been minimized.

Member

fkjagodzinski commented Jul 19, 2018

@jeromecoutant thanks for clarification, I did not check mbed_app.json. I still suggest updating the commit message though. RTOS SYSTIMER test error is ambiguous.

Systimer test : compilation error with MBED_TICKLESS
Issue occurs when "MBED_TICKLESS" is added in mbed_app.json,
not when "MBED_TICKLESS" is added in targets.json

@jeromecoutant jeromecoutant force-pushed the jeromecoutant:PR_RTOS_TICKLESS branch from 4b38dbc to 2550f3d Jul 19, 2018

@cmonr

cmonr approved these changes Jul 19, 2018

@cmonr cmonr added needs: CI and removed needs: work labels Jul 19, 2018

@cmonr

This comment has been minimized.

Contributor

cmonr commented Jul 19, 2018

/morph build

@mbed-ci

This comment has been minimized.

mbed-ci commented Jul 19, 2018

Build : SUCCESS

Build number : 2647
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/7530/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build
/morph mbed2-build

@mbed-ci

This comment has been minimized.

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Jul 20, 2018

/morph test

@mbed-ci

This comment has been minimized.

@0xc0170 0xc0170 added ready for merge and removed needs: CI labels Jul 23, 2018

@cmonr cmonr merged commit a252e5e into ARMmbed:master Jul 23, 2018

14 checks passed

AWS-CI uVisor Build & Test Success
Details
ci-morph-build build completed
Details
ci-morph-exporter build completed
Details
ci-morph-mbed2-build build completed
Details
ci-morph-test test completed
Details
continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
travis-ci/astyle Passed, 793 files
Details
travis-ci/docs Local docs testing has passed
Details
travis-ci/events Passed, runtime is 9568 cycles (-589 cycles)
Details
travis-ci/gitattributestest Local gitattributestest testing has passed
Details
travis-ci/licence_check Local licence_check testing has passed
Details
travis-ci/littlefs Passed, code size is 9960B (+0.00%)
Details
travis-ci/tools-py2.7 Local tools-py2.7 testing has passed
Details

@jeromecoutant jeromecoutant deleted the jeromecoutant:PR_RTOS_TICKLESS branch Aug 6, 2018

pan- pushed a commit to pan-/mbed that referenced this pull request Aug 22, 2018

Merge pull request ARMmbed#7530 from jeromecoutant/PR_RTOS_TICKLESS
RTOS SYSTIMER test error in TICKLESS mode
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment