New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

realtek rtl8195am remove DEVICE_EMAC #7551

Merged
merged 1 commit into from Jul 25, 2018

Conversation

Projects
None yet
5 participants
@M-ichae-l
Contributor

M-ichae-l commented Jul 19, 2018

Description

  • remove DEVICE_EMAC for wifi feature
  • fix for #7257

Pull request type

[X] Fix
realtek rtl8195am remove DEVICE_EMAC
1, remove DEVICE_EMAC for wifi feature

@0xc0170 0xc0170 requested a review from ARMmbed/mbed-os-ipcore Jul 19, 2018

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Jul 19, 2018

Why it was defined first place ? (why is this being removed now)

@M-ichae-l

This comment has been minimized.

Contributor

M-ichae-l commented Jul 19, 2018

@0xc0170
Please refer to #7257. A device should enable EMAC flag in targets.json only if its pure Ethernet. Rtl8195am is not pure Ethernet.
The DEVICE_EMAC macro should be removed in targets.json and related files.

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Jul 20, 2018

Thanks ! How is CONFIG_MBED_ENABLED related?

My questions might be answered by the commit message but could not find it there.

@M-ichae-l

This comment has been minimized.

Contributor

M-ichae-l commented Jul 20, 2018

@0xc0170
CONFIG_MBED_ENABLED is the macro that only used by RTL8195AM for internal SDK sync.

@SeppoTakalo

This comment has been minimized.

Contributor

SeppoTakalo commented Jul 23, 2018

@0xc0170 Seems like we don't have generic "this build is Mbed OS" flag available, so Realtek has been using this CONFIG_MBED_ENABLED macro, which already is enabled by their target.

Closest alternative would be MBED_CONF_RTOS_PRESENT but that could be disable by Mbed 2 builds.

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Jul 24, 2018

/morph build

@0xc0170 0xc0170 added needs: CI and removed needs: review labels Jul 24, 2018

@cmonr

This comment has been minimized.

Contributor

cmonr commented Jul 24, 2018

/morph build

@mbed-ci

This comment has been minimized.

mbed-ci commented Jul 24, 2018

Build : SUCCESS

Build number : 2665
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/7551/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build
/morph mbed2-build

@mbed-ci

This comment has been minimized.

@mbed-ci

This comment has been minimized.

@0xc0170 0xc0170 added ready for merge and removed needs: CI labels Jul 25, 2018

@0xc0170 0xc0170 merged commit 7adfcbe into ARMmbed:master Jul 25, 2018

14 checks passed

AWS-CI uVisor Build & Test Success
Details
ci-morph-build build completed
Details
ci-morph-exporter build completed
Details
ci-morph-mbed2-build build completed
Details
ci-morph-test test completed
Details
continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
travis-ci/astyle Passed, 793 files
Details
travis-ci/docs Local docs testing has passed
Details
travis-ci/events Passed, runtime is 8883 cycles (-1274 cycles)
Details
travis-ci/gitattributestest Local gitattributestest testing has passed
Details
travis-ci/licence_check Local licence_check testing has passed
Details
travis-ci/littlefs Passed, code size is 9960B (+0.00%)
Details
travis-ci/tools-py2.7 Local tools-py2.7 testing has passed
Details

@M-ichae-l M-ichae-l deleted the M-ichae-l:realtek-rtl8195am-remove-DEVICE_EMAC branch Jul 30, 2018

pan- pushed a commit to pan-/mbed that referenced this pull request Aug 22, 2018

Merge pull request ARMmbed#7551 from M-ichae-l/realtek-rtl8195am-remo…
…ve-DEVICE_EMAC

realtek rtl8195am remove DEVICE_EMAC
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment