New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nuvoton: Fix NUC472 SD-Host HW IP reset definition #7565

Merged
merged 3 commits into from Jul 31, 2018

Conversation

Projects
None yet
6 participants
@cyliangtw
Contributor

cyliangtw commented Jul 20, 2018

Description

This PR could fix the wrong definition of NUC472 SD-Host HW IP reset. The wrong definition will encounter EMAC reset as while call SD_Init().

Pull request type

[V] Fix
[ ] Refactor
[ ] New target
[ ] Feature
[ ] Breaking change

Test

Verified OK by cloud client v1.3.3

@0xc0170 0xc0170 requested a review from ARMmbed/mbed-os-ipcore Jul 20, 2018

@0xc0170 0xc0170 changed the title from Nuvoton: Fixed NUC472 SD-Host HW IP reset definition to Nuvoton: Fix NUC472 SD-Host HW IP reset definition Jul 25, 2018

@cyliangtw

This comment has been minimized.

Contributor

cyliangtw commented Jul 30, 2018

It's just only the chip specific HW IP reset wrong definition issue, not relative to mbed-os-core change manner. So, it seems not need to include all mbed-os-ipcore reviewers.
@0xc0170
@samchuarm

@SeppoTakalo

This comment has been minimized.

Contributor

SeppoTakalo commented Jul 30, 2018

@mikaleppanen Please review

@mikaleppanen

Result should be initialized, otherwise ok.

@@ -222,15 +222,17 @@ bool NUMAKER_EMAC::link_out(emac_mem_buf_t *buf)
{
bool result;

This comment has been minimized.

@mikaleppanen

mikaleppanen Jul 30, 2018

Contributor

Not changed in this pull request, but noticed that this is left uninitialized on error cases. Should be set false here or on goto to error jumps.

@cyliangtw

This comment has been minimized.

Contributor

cyliangtw commented Jul 31, 2018

@mikaleppanen , thanks of your advisement and it's fixed in commit 2fcbcf1

@0xc0170 0xc0170 added needs: CI and removed needs: review labels Jul 31, 2018

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Jul 31, 2018

/morph build

@mbed-ci

This comment has been minimized.

mbed-ci commented Jul 31, 2018

Build : SUCCESS

Build number : 2700
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/7565/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build
/morph mbed2-build

@mbed-ci

This comment has been minimized.

@mbed-ci

This comment has been minimized.

@cmonr cmonr merged commit 63f6216 into ARMmbed:master Jul 31, 2018

14 checks passed

AWS-CI uVisor Build & Test Success
Details
ci-morph-build build completed
Details
ci-morph-exporter build completed
Details
ci-morph-mbed2-build build completed
Details
ci-morph-test test completed
Details
continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
travis-ci/astyle Passed, 793 files
Details
travis-ci/docs Local docs testing has passed
Details
travis-ci/events Passed, runtime is 9998 cycles (+328 cycles)
Details
travis-ci/gitattributestest Local gitattributestest testing has passed
Details
travis-ci/licence_check Local licence_check testing has passed
Details
travis-ci/littlefs Passed, code size is 9960B (+0.00%)
Details
travis-ci/tools-py2.7 Local tools-py2.7 testing has passed
Details

pan- pushed a commit to pan-/mbed that referenced this pull request Aug 22, 2018

Merge pull request ARMmbed#7565 from OpenNuvoton/nuc472_emac_rst
Nuvoton: Fix NUC472 SD-Host HW IP reset definition
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment