New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor enhancement to wait_us #7584

Merged
merged 1 commit into from Jul 26, 2018

Conversation

Projects
None yet
4 participants
@SenRamakri
Contributor

SenRamakri commented Jul 23, 2018

Description

Minor enhancement to wait_us function to avoid integer division on all paths.

Pull request type

[x] Fix
[ ] Refactor
[ ] New target
[ ] Feature
[ ] Breaking change

@0xc0170 0xc0170 requested a review from ARMmbed/mbed-os-core Jul 25, 2018

@cmonr

LGTM, but will wait for the commit message to be modified (git commit --amend) with a bit more detail.

Something like "Improved resolution of wait_us by defering division operation"

@cmonr cmonr added needs: work and removed needs: review labels Jul 25, 2018

@SenRamakri SenRamakri force-pushed the SenRamakri:sen_wait_us_Enhancement branch from 1372e19 to 7cedccc Jul 25, 2018

@SenRamakri

This comment has been minimized.

Contributor

SenRamakri commented Jul 25, 2018

@cmonr - Please see my latest commit with modified commit message.

@cmonr

cmonr approved these changes Jul 25, 2018

@cmonr

This comment has been minimized.

Contributor

cmonr commented Jul 25, 2018

/morph build

@mbed-ci

This comment has been minimized.

mbed-ci commented Jul 25, 2018

Build : SUCCESS

Build number : 2674
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/7584/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build
/morph mbed2-build

@mbed-ci

This comment has been minimized.

@mbed-ci

This comment has been minimized.

@cmonr cmonr merged commit c5680b5 into ARMmbed:master Jul 26, 2018

14 checks passed

AWS-CI uVisor Build & Test Success
Details
ci-morph-build build completed
Details
ci-morph-exporter build completed
Details
ci-morph-mbed2-build build completed
Details
ci-morph-test test completed
Details
continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
travis-ci/astyle Passed, 793 files
Details
travis-ci/docs Local docs testing has passed
Details
travis-ci/events Passed, runtime is 10299 cycles (+615 cycles)
Details
travis-ci/gitattributestest Local gitattributestest testing has passed
Details
travis-ci/licence_check Local licence_check testing has passed
Details
travis-ci/littlefs Passed, code size is 9960B (+0.00%)
Details
travis-ci/tools-py2.7 Local tools-py2.7 testing has passed
Details

pan- pushed a commit to pan-/mbed that referenced this pull request Aug 22, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment