New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nuvoton: Replace __wrap__sbrk with overriding _sbrk #7603

Merged
merged 1 commit into from Jul 26, 2018

Conversation

Projects
None yet
4 participants
@ccli8
Contributor

ccli8 commented Jul 26, 2018

Description

With _sbrk being weak (#5994), this PR replaces __wrap__sbrk with overriding _sbrk to support heap with two-region model on Nuvoton targets.

Pull request type

[ ] Fix
[X] Refactor
[ ] New target
[ ] Feature
[ ] Breaking change
[Nuvoton] Replace __wrap__sbrk with overriding _sbrk
With _sbrk being weak, we can override it directly rather than #if to support heap with
two-region model.

@0xc0170 0xc0170 requested a review from ARMmbed/mbed-os-hal Jul 26, 2018

@cmonr

cmonr approved these changes Jul 26, 2018

@cmonr

This comment has been minimized.

Contributor

cmonr commented Jul 26, 2018

/morph build

@cmonr cmonr added needs: CI and removed needs: review labels Jul 26, 2018

@mbed-ci

This comment has been minimized.

mbed-ci commented Jul 26, 2018

Build : SUCCESS

Build number : 2676
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/7603/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build
/morph mbed2-build

@mbed-ci

This comment has been minimized.

@mbed-ci

This comment has been minimized.

@cmonr cmonr merged commit cc506ee into ARMmbed:master Jul 26, 2018

14 checks passed

AWS-CI uVisor Build & Test Success
Details
ci-morph-build build completed
Details
ci-morph-exporter build completed
Details
ci-morph-mbed2-build build completed
Details
ci-morph-test test completed
Details
continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
travis-ci/astyle Passed, 793 files
Details
travis-ci/docs Local docs testing has passed
Details
travis-ci/events Passed, runtime is 8889 cycles (-795 cycles)
Details
travis-ci/gitattributestest Local gitattributestest testing has passed
Details
travis-ci/licence_check Local licence_check testing has passed
Details
travis-ci/littlefs Passed, code size is 9960B (+0.00%)
Details
travis-ci/tools-py2.7 Local tools-py2.7 testing has passed
Details

@0xc0170 0xc0170 removed the needs: CI label Jul 26, 2018

@ccli8 ccli8 deleted the OpenNuvoton:nuvoton_override_gcc_sbrk branch Jul 27, 2018

pan- pushed a commit to pan-/mbed that referenced this pull request Aug 22, 2018

Merge pull request ARMmbed#7603 from OpenNuvoton/nuvoton_override_gcc…
…_sbrk

Nuvoton: Replace __wrap__sbrk with overriding _sbrk
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment