New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tools: Correct `win_to_unix` path handling #7608

Merged
merged 2 commits into from Jul 26, 2018

Conversation

Projects
None yet
4 participants
@theotherjimmy
Contributor

theotherjimmy commented Jul 26, 2018

Description

After #7183, many problems cropped up WRT exporters handling of include
paths. This was related to my naive use of os.sep. After calling
win_to_unix, the seperator for the resources object is forced to /.
This PR makes that behaivor explicit by keeping the seperator around.

Pull request type

[x] Fix
[ ] Refactor
[ ] New target
[ ] Feature
[ ] Breaking change

@theotherjimmy theotherjimmy force-pushed the theotherjimmy:fix-make branch from 693fe50 to f9c6f21 Jul 26, 2018

@0xc0170 0xc0170 requested a review from cmonr Jul 26, 2018

@cmonr

cmonr approved these changes Jul 26, 2018

@cmonr

This comment has been minimized.

Contributor

cmonr commented Jul 26, 2018

/morph build

@mbed-ci

This comment has been minimized.

mbed-ci commented Jul 26, 2018

Build : SUCCESS

Build number : 2677
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/7608/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build
/morph mbed2-build

@mbed-ci

This comment has been minimized.

@mbed-ci

This comment has been minimized.

@cmonr cmonr merged commit 639285a into ARMmbed:master Jul 26, 2018

14 checks passed

AWS-CI uVisor Build & Test Success
Details
ci-morph-build build completed
Details
ci-morph-exporter build completed
Details
ci-morph-mbed2-build build completed
Details
ci-morph-test test completed
Details
continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
travis-ci/astyle Passed, 793 files
Details
travis-ci/docs Local docs testing has passed
Details
travis-ci/events Passed, runtime is 9711 cycles
Details
travis-ci/gitattributestest Local gitattributestest testing has passed
Details
travis-ci/licence_check Local licence_check testing has passed
Details
travis-ci/littlefs Passed, code size is 9960B
Details
travis-ci/tools-py2.7 Local tools-py2.7 testing has passed
Details

@0xc0170 0xc0170 removed the needs: CI label Jul 26, 2018

pan- pushed a commit to pan-/mbed that referenced this pull request Aug 22, 2018

Merge pull request ARMmbed#7608 from theotherjimmy/fix-make
Tools: Correct `win_to_unix` path handling
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment