New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lora: Fix cancel_sending #7620

Merged
merged 1 commit into from Aug 1, 2018

Conversation

Projects
None yet
5 participants
@kivaisan
Contributor

kivaisan commented Jul 27, 2018

Description

This commit fixes some bugs from cancel_sending() method:

  • System crashed if method was called before initialization.
    Now LORAWAN_STATUS_NOT_INITIALIZED will be returned.
  • Method returned LORAWAN_STATUS_BUSY error when no send request was pending.
    LORAWAN_STATUS_OK should be returned in this case.
  • LORAWAN_STATUS_BUSY is now returned if backoff timer is just about to be
    dispatched (time_left returns 0).

Pull request type

[X] Fix
[ ] Refactor
[ ] New target
[ ] Feature
[ ] Breaking change
Lora: Fix cancel_sending
This commit fixes some bugs from cancel_sending() method:
-  System crashed if method was called before initialization.
   Now LORAWAN_STATUS_NOT_INITIALIZED will be returned.
-  Method returned LORAWAN_STATUS_BUSY error when no send request was pending.
   LORAWAN_STATUS_OK should be returned in this case.
-  LORAWAN_STATUS_BUSY is now returned if backoff timer is just about to be
   dispatched (time_left returns 0).
@kivaisan

This comment has been minimized.

Contributor

kivaisan commented Jul 27, 2018

@hasnainvirk please review.

@0xc0170 0xc0170 requested a review from ARMmbed/mbed-os-wan Jul 27, 2018

@hasnainvirk

Looks good.

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Jul 31, 2018

/morph build

@0xc0170 0xc0170 added needs: CI and removed needs: review labels Jul 31, 2018

@mbed-ci

This comment has been minimized.

mbed-ci commented Jul 31, 2018

Build : SUCCESS

Build number : 2704
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/7620/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build
/morph mbed2-build

@cmonr

cmonr approved these changes Jul 31, 2018

@mbed-ci

This comment has been minimized.

@mbed-ci

This comment has been minimized.

@cmonr cmonr added ready for merge and removed needs: CI labels Jul 31, 2018

@0xc0170 0xc0170 merged commit 03ad9d6 into ARMmbed:master Aug 1, 2018

14 checks passed

AWS-CI uVisor Build & Test Success
Details
ci-morph-build build completed
Details
ci-morph-exporter build completed
Details
ci-morph-mbed2-build build completed
Details
ci-morph-test test completed
Details
continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
travis-ci/astyle Passed, 793 files
Details
travis-ci/docs Local docs testing has passed
Details
travis-ci/events Passed, runtime is 9683 cycles (+13 cycles)
Details
travis-ci/gitattributestest Local gitattributestest testing has passed
Details
travis-ci/licence_check Local licence_check testing has passed
Details
travis-ci/littlefs Passed, code size is 9960B (+0.00%)
Details
travis-ci/tools-py2.7 Local tools-py2.7 testing has passed
Details

@0xc0170 0xc0170 removed the ready for merge label Aug 1, 2018

pan- pushed a commit to pan-/mbed that referenced this pull request Aug 22, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment