New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tools: Fix incrimental compile dep tracking #7646

Merged
merged 2 commits into from Aug 1, 2018

Conversation

Projects
None yet
5 participants
@theotherjimmy
Contributor

theotherjimmy commented Jul 30, 2018

Description

I recently introduced a general purpose function for creating command files.
This function used the hash in naming the file, but not in checking for
updates. This PR corrects the incrimental compile behavior of links.

In the process, I noticed that mbed_config.h changes every compile under
python 3. I'll be correcting that shortly. That should be resolved now

TODO

  • Fix incrimental flags for linker
  • Fix Python 3 mbed_config.h orering

Pull request type

[x] Fix
[ ] Refactor
[ ] New target
[ ] Feature
[ ] Breaking change

@cmonr cmonr self-requested a review Jul 30, 2018

@cmonr cmonr added the needs: review label Jul 30, 2018

@cmonr

cmonr approved these changes Jul 31, 2018

@cmonr

This comment has been minimized.

Contributor

cmonr commented Jul 31, 2018

Interesting to know that Py3 doesn't sort by default.

/morph build

@mbed-ci

This comment has been minimized.

mbed-ci commented Jul 31, 2018

Build : SUCCESS

Build number : 2712
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/7646/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build
/morph mbed2-build

@mbed-ci

This comment has been minimized.

@mbed-ci

This comment has been minimized.

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Aug 1, 2018

/morph test

@mbed-ci

This comment has been minimized.

@cmonr cmonr added ready for merge and removed needs: CI labels Aug 1, 2018

@cmonr cmonr merged commit 7f73a6d into ARMmbed:master Aug 1, 2018

14 checks passed

AWS-CI uVisor Build & Test Success
Details
ci-morph-build build completed
Details
ci-morph-exporter build completed
Details
ci-morph-mbed2-build build completed
Details
ci-morph-test test completed
Details
continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
travis-ci/astyle Passed, 793 files
Details
travis-ci/docs Local docs testing has passed
Details
travis-ci/events Passed, runtime is 8985 cycles (-685 cycles)
Details
travis-ci/gitattributestest Local gitattributestest testing has passed
Details
travis-ci/licence_check Local licence_check testing has passed
Details
travis-ci/littlefs Passed, code size is 9960B (+0.00%)
Details
travis-ci/tools-py2.7 Local tools-py2.7 testing has passed
Details

@cmonr cmonr removed the ready for merge label Aug 2, 2018

pan- pushed a commit to pan-/mbed that referenced this pull request Aug 22, 2018

Merge pull request ARMmbed#7646 from theotherjimmy/fix-incr
Tools: Fix incrimental compile dep tracking
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment