New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove device emac check from emac greentea tests #7655

Merged
merged 1 commit into from Aug 1, 2018

Conversation

Projects
None yet
6 participants
@mikaleppanen
Contributor

mikaleppanen commented Jul 31, 2018

Description

DEVICE_EMAC is defined only for boards with default Ethernet emac. It is not defined for example for Realtek RTL8195AM board that does not have Ethernet. Removed the check for device emac from emac greentea tests.

Pull request type

[X] Fix
[ ] Refactor
[ ] New target
[ ] Feature
[ ] Breaking change
Removed device emac check from emac greentea tests
DEVICE_EMAC is defined only for boards with default Ethernet emac.
It is not defined for example for Realtek RTL8195AM board that
does not have Ethernet. Removed the check for device emac from emac
greentea tests.
@mikaleppanen

This comment has been minimized.

Contributor

mikaleppanen commented Jul 31, 2018

@juhaylinen After this fix, there should not be need to define override for target device EMAC when building emac greentea tests.

@0xc0170 0xc0170 changed the title from Removed device emac check from emac greentea tests to Remove device emac check from emac greentea tests Jul 31, 2018

@0xc0170 0xc0170 requested a review from ARMmbed/mbed-os-ipcore Jul 31, 2018

@0xc0170 0xc0170 added needs: CI and removed needs: review labels Jul 31, 2018

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Jul 31, 2018

/morph build

@mbed-ci

This comment has been minimized.

mbed-ci commented Jul 31, 2018

Build : SUCCESS

Build number : 2702
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/7655/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build
/morph mbed2-build

@mbed-ci

This comment has been minimized.

@mbed-ci

This comment has been minimized.

@cmonr cmonr added ready for merge and removed needs: CI labels Jul 31, 2018

@0xc0170 0xc0170 merged commit 1a7ff86 into ARMmbed:master Aug 1, 2018

14 checks passed

AWS-CI uVisor Build & Test Success
Details
ci-morph-build build completed
Details
ci-morph-exporter build completed
Details
ci-morph-mbed2-build build completed
Details
ci-morph-test test completed
Details
continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
travis-ci/astyle Passed, 793 files
Details
travis-ci/docs Local docs testing has passed
Details
travis-ci/events Passed, runtime is 10174 cycles (+504 cycles)
Details
travis-ci/gitattributestest Local gitattributestest testing has passed
Details
travis-ci/licence_check Local licence_check testing has passed
Details
travis-ci/littlefs Passed, code size is 9960B (+0.00%)
Details
travis-ci/tools-py2.7 Local tools-py2.7 testing has passed
Details

@0xc0170 0xc0170 removed the ready for merge label Aug 1, 2018

pan- pushed a commit to pan-/mbed that referenced this pull request Aug 22, 2018

Merge pull request ARMmbed#7655 from mikaleppanen/emac_gt_rm_emac_check
Remove device emac check from emac greentea tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment