New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move BlockDevice classes inside mbed namespace #7663

Merged
merged 2 commits into from Aug 8, 2018

Conversation

Projects
None yet
6 participants
@deepikabhavnani
Contributor

deepikabhavnani commented Jul 31, 2018

Description

Move BlockDevice classes inside mbed namespace. Resolves: #6684

Dependent on PR: ##7660

Pull request type

[X] Fix
[ ] Refactor
[ ] New target
[ ] Feature
[ ] Breaking change

@deepikabhavnani deepikabhavnani force-pushed the deepikabhavnani:namespace_bd_update branch from 0bcb34c to 5832811 Jul 31, 2018

@cmonr cmonr requested a review from ARMmbed/mbed-os-storage Jul 31, 2018

@deepikabhavnani

This comment has been minimized.

Contributor

deepikabhavnani commented Aug 1, 2018

Will resolve conflict and rebase once #7660 is in.

@deepikabhavnani deepikabhavnani force-pushed the deepikabhavnani:namespace_bd_update branch from 5832811 to e36cd00 Aug 3, 2018

@deepikabhavnani

This comment has been minimized.

Contributor

deepikabhavnani commented Aug 3, 2018

Rebased + preceding PR merged

@davidsaada

Looks good to me.

@0xc0170

0xc0170 approved these changes Aug 6, 2018

@geky

geky approved these changes Aug 6, 2018

Looks good to me too 👍

@0xc0170 0xc0170 added needs: CI and removed needs: review labels Aug 6, 2018

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Aug 6, 2018

/morph build

@mbed-ci

This comment has been minimized.

mbed-ci commented Aug 6, 2018

@deepikabhavnani

This comment has been minimized.

Contributor

deepikabhavnani commented Aug 6, 2018

trying build after adding missing header file

/morph build

@cmonr

This comment has been minimized.

Contributor

cmonr commented Aug 7, 2018

/morph build

@mbed-ci

This comment has been minimized.

mbed-ci commented Aug 7, 2018

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Aug 7, 2018

Build failure indicates missing header file inclusion (I found at least memset there)

@deepikabhavnani deepikabhavnani force-pushed the deepikabhavnani:namespace_bd_update branch from 3a82791 to 8f2f6f4 Aug 7, 2018

@cmonr

This comment has been minimized.

Contributor

cmonr commented Aug 7, 2018

/morph build

@mbed-ci

This comment has been minimized.

mbed-ci commented Aug 7, 2018

Build : SUCCESS

Build number : 2755
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/7663/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build
/morph mbed2-build

@mbed-ci

This comment has been minimized.

@mbed-ci

This comment has been minimized.

@cmonr cmonr added ready for merge and removed needs: CI labels Aug 7, 2018

@cmonr cmonr merged commit 509869d into ARMmbed:master Aug 8, 2018

14 checks passed

AWS-CI uVisor Build & Test Success
Details
ci-morph-build build completed
Details
ci-morph-exporter build completed
Details
ci-morph-mbed2-build build completed
Details
ci-morph-test test completed
Details
continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
travis-ci/astyle Passed, 569 files
Details
travis-ci/docs Local docs testing has passed
Details
travis-ci/events Passed, runtime is 10182 cycles
Details
travis-ci/gitattributestest Local gitattributestest testing has passed
Details
travis-ci/licence_check Local licence_check testing has passed
Details
travis-ci/littlefs Passed, code size is 9960B
Details
travis-ci/tools-py2.7 Local tools-py2.7 testing has passed
Details

@0xc0170 0xc0170 removed the ready for merge label Aug 8, 2018

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Aug 9, 2018

This should definitely be up for the next feature release (I would go for major if this breaks whoever includes just blockdevice and use it without mbed.h inclusion in the code - will require good documentation to migrate the code !), not patch. Still would like to check how to mitigate adding the namespace to BlockDevice.

FATFileSystem is not yet in the mbed namespace (isn't this also our implementation) ? Intention there ?

@deepikabhavnani deepikabhavnani deleted the deepikabhavnani:namespace_bd_update branch Aug 9, 2018

@deepikabhavnani

This comment has been minimized.

Contributor

deepikabhavnani commented Aug 9, 2018

FATFileSystem is not yet in the mbed namespace (isn't this also our implementation) ? Intention there ?

FatFileSystem is our implementation but it used ChanFs so was not sure if we can have it inside mbed namespace. Same is true for LittleFileSystem

@deepikabhavnani

This comment has been minimized.

Contributor

deepikabhavnani commented Aug 9, 2018

will require good documentation to migrate the code !),

@0xc0170 @AnotherButler - Please suggest the good place to capture this change. All our examples use "mbed.h" and since class reference is directly pulled from code it will have namespace in reference.

@geky

This comment has been minimized.

Member

geky commented Aug 9, 2018

Both FATFileSystem and LittleFileSystem should be inside mbed namespace.

IMO All classes in mbed-os should be inside the mbed namespace. I don't know of any reasons this shouldn't be true.

@0xc0170 +1 For holding this until a minor release

@deepikabhavnani deepikabhavnani restored the deepikabhavnani:namespace_bd_update branch Aug 10, 2018

@deepikabhavnani deepikabhavnani deleted the deepikabhavnani:namespace_bd_update branch Aug 10, 2018

pan- pushed a commit to pan-/mbed that referenced this pull request Aug 22, 2018

Merge pull request ARMmbed#7663 from deepikabhavnani/namespace_bd_update
Move BlockDevice classes inside mbed namespace
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment