New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Renesas : Improve Flash iap #7675

Merged
merged 1 commit into from Aug 2, 2018

Conversation

Projects
None yet
5 participants
@TomoYamanaka
Contributor

TomoYamanaka commented Aug 2, 2018

Description

I revised flash_iap.c file of Renesas.

I modified the _page_program() because when request size is over the maximum size(256 byte) per one writing, it was not able to loop the writing every 256 byte.
Also I modified the return value of flash_get_page_size() because the minimum size per one writing was 1 byte by Flash spec.
FLASH_PAGE_SIZE macro is remain 256, it doesn't be used at flash_get_page_size(), used at _page_program() as the maximum page size.

Relation Issue

#7649 (comment)

Test result

NVStore and Flash iAP was passed.

Test_PEACH_GCC_NVStore_Flash.txt
Test_LYCHEE_GCC_NVStore_Flash.txt

Pull request type

[x] Fix
[ ] Refactor
[ ] New target
[ ] Feature
[ ] Breaking change
Renesas : Improve Flash iap
I modified the _page_program() because when the request of the size exceeding the maximum size(256 byte) per one writing of Flash recieved, it was not able to loop the writing with sifting the address every 256 byte.

Also I modified the return value of flash_get_page_size() because I found that the minimum size per one writing of Flash is 1 byte by reviewing Flash spec.
"FLASH_PAGE_SIZE" macro's value is remain 256, it doesn't be used at flash_get_page_size(), used at _page_program() for refferencing of the maximum page size.
@0xc0170

0xc0170 approved these changes Aug 2, 2018

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Aug 2, 2018

/morph build

@0xc0170 0xc0170 added needs: CI and removed needs: review labels Aug 2, 2018

@mbed-ci

This comment has been minimized.

mbed-ci commented Aug 2, 2018

Build : SUCCESS

Build number : 2721
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/7675/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build
/morph mbed2-build

@mbed-ci

This comment has been minimized.

@mbed-ci

This comment has been minimized.

@0xc0170 0xc0170 added ready for merge and removed needs: CI labels Aug 2, 2018

@cmonr cmonr merged commit e016d8d into ARMmbed:master Aug 2, 2018

14 checks passed

AWS-CI uVisor Build & Test Success
Details
ci-morph-build build completed
Details
ci-morph-exporter build completed
Details
ci-morph-mbed2-build build completed
Details
ci-morph-test test completed
Details
continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
travis-ci/astyle Passed, 703 files
Details
travis-ci/docs Local docs testing has passed
Details
travis-ci/events Passed, runtime is 10386 cycles (+1436 cycles)
Details
travis-ci/gitattributestest Local gitattributestest testing has passed
Details
travis-ci/licence_check Local licence_check testing has passed
Details
travis-ci/littlefs Passed, code size is 9960B (+0.00%)
Details
travis-ci/tools-py2.7 Local tools-py2.7 testing has passed
Details

@0xc0170 0xc0170 removed the ready for merge label Aug 2, 2018

@TomoYamanaka TomoYamanaka deleted the TomoYamanaka:improve_flashiap branch Aug 3, 2018

pan- pushed a commit to pan-/mbed that referenced this pull request Aug 22, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment