Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BLE: store secure connections ltk in both local and peer entry #7681

Merged
merged 1 commit into from Aug 20, 2018

Conversation

paul-szczepanek-arm
Copy link
Member

Description

Secure connections LTK was being stored only in the peer entry which meant the remote encryption request wouldn't find the correct key. This fix stores the key in both entries.

Pull request type

[X] Fix
[ ] Refactor
[ ] New target
[ ] Feature
[ ] Breaking change

@pan-
Copy link
Member

pan- commented Aug 3, 2018

Please backport the other fixes.

@paul-szczepanek-arm
Copy link
Member Author

paul-szczepanek-arm commented Aug 3, 2018

will do:
#7687
#7688

@cmonr
Copy link
Contributor

cmonr commented Aug 14, 2018

/morph build

@mbed-ci
Copy link

mbed-ci commented Aug 14, 2018

Build : SUCCESS

Build number : 2795
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/7681/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build
/morph mbed2-build

@mbed-ci
Copy link

mbed-ci commented Aug 14, 2018

@cmonr
Copy link
Contributor

cmonr commented Aug 14, 2018

/morph test

@mbed-ci
Copy link

mbed-ci commented Aug 15, 2018

@adbridge
Copy link
Contributor

Looks like this has failed due to some networking issues in CI. Suggest we re-run this once the CI is less heavily loaded.

@cmonr
Copy link
Contributor

cmonr commented Aug 16, 2018

/morph test

@mbed-ci
Copy link

mbed-ci commented Aug 17, 2018

@cmonr
Copy link
Contributor

cmonr commented Aug 17, 2018

/morph test

@mbed-ci
Copy link

mbed-ci commented Aug 17, 2018

@cmonr
Copy link
Contributor

cmonr commented Aug 17, 2018

Well then. Neither of those test failures appear to be caused by the PR, and we've been seeing them all week.

/morph test

@mbed-ci
Copy link

mbed-ci commented Aug 18, 2018

@0xc0170 0xc0170 merged commit e43f020 into ARMmbed:master Aug 20, 2018
pan- pushed a commit to pan-/mbed that referenced this pull request Aug 22, 2018
BLE: store secure connections ltk in both local and peer entry
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants