New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BLE: store secure connections ltk in both local and peer entry #7681

Merged
merged 1 commit into from Aug 20, 2018

Conversation

Projects
None yet
6 participants
@paul-szczepanek-arm
Member

paul-szczepanek-arm commented Aug 2, 2018

Description

Secure connections LTK was being stored only in the peer entry which meant the remote encryption request wouldn't find the correct key. This fix stores the key in both entries.

Pull request type

[X] Fix
[ ] Refactor
[ ] New target
[ ] Feature
[ ] Breaking change

@0xc0170 0xc0170 requested a review from ARMmbed/mbed-os-pan Aug 2, 2018

@0xc0170

0xc0170 approved these changes Aug 3, 2018

@pan-

pan- approved these changes Aug 3, 2018

@pan-

This comment has been minimized.

Member

pan- commented Aug 3, 2018

Please backport the other fixes.

@paul-szczepanek-arm

This comment has been minimized.

Member

paul-szczepanek-arm commented Aug 3, 2018

will do:
#7687
#7688

@cmonr

This comment has been minimized.

Contributor

cmonr commented Aug 14, 2018

/morph build

@mbed-ci

This comment has been minimized.

mbed-ci commented Aug 14, 2018

Build : SUCCESS

Build number : 2795
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/7681/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build
/morph mbed2-build

@mbed-ci

This comment has been minimized.

@cmonr

This comment has been minimized.

Contributor

cmonr commented Aug 14, 2018

/morph test

@mbed-ci

This comment has been minimized.

@adbridge

This comment has been minimized.

Contributor

adbridge commented Aug 15, 2018

Looks like this has failed due to some networking issues in CI. Suggest we re-run this once the CI is less heavily loaded.

@cmonr

This comment has been minimized.

Contributor

cmonr commented Aug 16, 2018

/morph test

@mbed-ci

This comment has been minimized.

@cmonr

This comment has been minimized.

Contributor

cmonr commented Aug 17, 2018

/morph test

@mbed-ci

This comment has been minimized.

@cmonr

This comment has been minimized.

Contributor

cmonr commented Aug 17, 2018

Well then. Neither of those test failures appear to be caused by the PR, and we've been seeing them all week.

/morph test

@mbed-ci

This comment has been minimized.

@0xc0170 0xc0170 added ready for merge and removed needs: CI labels Aug 20, 2018

@0xc0170 0xc0170 merged commit e43f020 into ARMmbed:master Aug 20, 2018

14 checks passed

AWS-CI uVisor Build & Test Success
Details
ci-morph-build build completed
Details
ci-morph-exporter build completed
Details
ci-morph-mbed2-build build completed
Details
ci-morph-test test completed , RTOS ROM(+0.0%) RAM(+0.0%)
Details
continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
travis-ci/astyle Passed, 703 files
Details
travis-ci/docs Local docs testing has passed
Details
travis-ci/events Passed, runtime is 9602 cycles (+652 cycles)
Details
travis-ci/gitattributestest Local gitattributestest testing has passed
Details
travis-ci/licence_check Local licence_check testing has passed
Details
travis-ci/littlefs Passed, code size is 9960B (+0.00%)
Details
travis-ci/tools-py2.7 Local tools-py2.7 testing has passed
Details

pan- pushed a commit to pan-/mbed that referenced this pull request Aug 22, 2018

Merge pull request ARMmbed#7681 from paul-szczepanek-arm/sc-ltk
BLE: store secure connections ltk in both local and peer entry
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment