New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct MTB_ADV_WISE_1530 led configuration #7686

Merged
merged 1 commit into from Aug 13, 2018

Conversation

Projects
None yet
6 participants
@KariHaapalehto
Contributor

KariHaapalehto commented Aug 3, 2018

mbed-os-example_blinky didn't work with MTB_ADV_WISE_1530, so led configuration have been updated. Also minor update to MTB_MXCHIP_EMW3166 led configuration, led3 is now
defined but not connected.

Description

mbed-os-example-blinky have been tested and verified with these 3 boards:
MTB_ADV_WISE_1530
MTB_USI_WM_BN_BM_22
MTB_MXCHIP_EMW

Pull request type

[X] Fix
[ ] Refactor
[ ] New target
[ ] Feature
[ ] Breaking change
mbed-os-example_blinky didn't work with wise-1530, so MTB_ADV_WISE_1530
led configuration have been updated.
Also minor update to MTB_MXCHIP_EMW3166 led configuration, led3 is now
defined but not connected.
@KariHaapalehto

This comment has been minimized.

Contributor

KariHaapalehto commented Aug 3, 2018

@SeppoTakalo, please review

@0xc0170 0xc0170 requested review from SeppoTakalo and ashok-rao Aug 3, 2018

@@ -201,6 +201,7 @@ typedef enum {
// Generic signals namings
LED1 = PB_2,
LED2 = PB_10,
LED3 = NC,

This comment has been minimized.

@ashok-rao

ashok-rao Aug 3, 2018

Contributor

@KariHaapalehto : I'm not clear why is this required?

This comment has been minimized.

@KariHaapalehto

KariHaapalehto Aug 3, 2018

Contributor

It is not required, but all MTB's do have 3 different led's so I would like to identyfy that there is 3rd led available but it is not connected.

"config": {
"led1": "PA_4",
"led2": "PC_12",
"led3": "NC"

This comment has been minimized.

@ashok-rao

ashok-rao Aug 3, 2018

Contributor

same comment as above. why is led3 required if not connected? Also, this may not be for this particular PR, but looks like there is a naming issue here.. the parent target is "USI_xxx" (note: manf = USI), and ADV target inherits from it.. (note: manf = ADV). We may want to change this in the future.

This comment has been minimized.

@SeppoTakalo

SeppoTakalo Aug 7, 2018

Contributor

MTB has 3 leds, so all MTB targets should define those. But unfortunately all MCBs don't connect those leds, so those that don't need NC instead.

@ashok-rao

I'm not entirely sure why LED3 define is even required here..?

"config": {
"led1": "PA_4",
"led2": "PC_12",
"led3": "NC"

This comment has been minimized.

@SeppoTakalo

SeppoTakalo Aug 7, 2018

Contributor

MTB has 3 leds, so all MTB targets should define those. But unfortunately all MCBs don't connect those leds, so those that don't need NC instead.

@0xc0170

0xc0170 approved these changes Aug 7, 2018

@KariHaapalehto

This comment has been minimized.

Contributor

KariHaapalehto commented Aug 10, 2018

Can this be merged?
Or is this still waiting someting?

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Aug 10, 2018

/morph build

@0xc0170 0xc0170 added needs: CI and removed needs: review labels Aug 10, 2018

@mbed-ci

This comment has been minimized.

mbed-ci commented Aug 10, 2018

Build : SUCCESS

Build number : 2775
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/7686/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build
/morph mbed2-build

@mbed-ci

This comment has been minimized.

@mbed-ci

This comment has been minimized.

@0xc0170 0xc0170 added ready for merge and removed needs: CI labels Aug 10, 2018

@cmonr cmonr merged commit 0e68570 into ARMmbed:master Aug 13, 2018

14 checks passed

AWS-CI uVisor Build & Test Success
Details
ci-morph-build build completed
Details
ci-morph-exporter build completed
Details
ci-morph-mbed2-build build completed
Details
ci-morph-test test completed
Details
continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
travis-ci/astyle Passed, 705 files
Details
travis-ci/docs Local docs testing has passed
Details
travis-ci/events Passed, runtime is 9227 cycles (-356 cycles)
Details
travis-ci/gitattributestest Local gitattributestest testing has passed
Details
travis-ci/licence_check Local licence_check testing has passed
Details
travis-ci/littlefs Passed, code size is 9960B (+0.00%)
Details
travis-ci/tools-py2.7 Local tools-py2.7 testing has passed
Details

pan- pushed a commit to pan-/mbed that referenced this pull request Aug 22, 2018

Merge pull request ARMmbed#7686 from KariHaapalehto/1530_led
Correct MTB_ADV_WISE_1530 led configuration
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment