New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Microlib compatibility for -t ARM #7722

Merged
merged 1 commit into from Aug 9, 2018

Conversation

Projects
None yet
4 participants
@theotherjimmy
Contributor

theotherjimmy commented Aug 7, 2018

Description

Missing from common flags:

  • -D__MICROLIB
  • --library_type=microlib

This patch adds them

Pull request type

[x] Fix
[ ] Refactor
[ ] New target
[ ] Feature
[ ] Breaking change
Fix Microlib compatibility for -t ARM
Missing from common flags:
 * `-D__MICROLIB`
 * `--library_type=microlib`

This patch adds them
@cmonr

This comment has been minimized.

Contributor

cmonr commented Aug 8, 2018

I thought that microlib was only invoked within the ARM compiler when uARM was used.

@cmonr cmonr self-assigned this Aug 8, 2018

@cmonr cmonr requested a review from 0xc0170 Aug 8, 2018

@cmonr cmonr added the needs: review label Aug 8, 2018

@cmonr

This comment has been minimized.

Contributor

cmonr commented Aug 8, 2018

Also, is this fixing a particualr issue, or something you noticed and came across?

@cmonr cmonr removed their assignment Aug 8, 2018

@cmonr cmonr self-requested a review Aug 8, 2018

@0xc0170

0xc0170 approved these changes Aug 8, 2018

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Aug 8, 2018

Also, is this fixing a particualr issue, or something you noticed and came across?

This should be a fix (dont recall particular issue reported here though). I would have assumed only linker symbol is needed but if we build static lib, also common one is needed (reference http://www.keil.com/support/man/docs/armlib/armlib_chr1358938939195.htm). The symbol is added by uvision if you enable microlib there.

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Aug 8, 2018

/morph build

@mbed-ci

This comment has been minimized.

mbed-ci commented Aug 8, 2018

Build : SUCCESS

Build number : 2760
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/7722/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build
/morph mbed2-build

@mbed-ci

This comment has been minimized.

@mbed-ci

This comment has been minimized.

@cmonr

This comment has been minimized.

Contributor

cmonr commented Aug 9, 2018

Single failure appears to possibly be due to multiplicly defined asm symbols bug that crops up every once in a while.
/morph export-build

And DNS test has been on and off this week.
/morph test

@cmonr

This comment has been minimized.

Contributor

cmonr commented Aug 9, 2018

/morph test

@mbed-ci

This comment has been minimized.

@mbed-ci

This comment has been minimized.

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Aug 9, 2018

/morph test

@mbed-ci

This comment has been minimized.

@cmonr cmonr added ready for merge and removed needs: CI labels Aug 9, 2018

@cmonr

cmonr approved these changes Aug 9, 2018

@cmonr cmonr merged commit e923bbd into ARMmbed:master Aug 9, 2018

14 checks passed

AWS-CI uVisor Build & Test Success
Details
ci-morph-build build completed
Details
ci-morph-exporter build completed
Details
ci-morph-mbed2-build build completed
Details
ci-morph-test test completed
Details
continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
travis-ci/astyle Passed, 566 files
Details
travis-ci/docs Local docs testing has passed
Details
travis-ci/events Passed, runtime is 10061 cycles (+995 cycles)
Details
travis-ci/gitattributestest Local gitattributestest testing has passed
Details
travis-ci/licence_check Local licence_check testing has passed
Details
travis-ci/littlefs Passed, code size is 9960B (+0.00%)
Details
travis-ci/tools-py2.7 Local tools-py2.7 testing has passed
Details

@0xc0170 0xc0170 removed the ready for merge label Aug 9, 2018

pan- pushed a commit to pan-/mbed that referenced this pull request Aug 22, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment