New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename text region in ARM linker file for Renesas & Realtek boards #7729

Merged
merged 1 commit into from Aug 9, 2018

Conversation

Projects
None yet
6 participants
@davidsaada
Contributor

davidsaada commented Aug 8, 2018

Description

Continuing the work from #7242, to name the text load region LR_IROM1. This is required for uniformity sake, claiming that this should be the region name for all boards (also mentioned in Handbook). Work is done here on few Renesas and Realtek boards.

Pull request type

[x] Fix
[ ] Refactor
[ ] Target update
[ ] Feature
[ ] Breaking change
@0xc0170

0xc0170 approved these changes Aug 8, 2018

@cmonr

cmonr approved these changes Aug 8, 2018

@cmonr

This comment has been minimized.

Contributor

cmonr commented Aug 9, 2018

/morph build

@mbed-ci

This comment has been minimized.

mbed-ci commented Aug 9, 2018

Build : SUCCESS

Build number : 2768
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/7729/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build
/morph mbed2-build

@mbed-ci

This comment has been minimized.

@mbed-ci

This comment has been minimized.

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Aug 9, 2018

Timeout

/morph test

@mbed-ci

This comment has been minimized.

@cmonr cmonr added ready for merge and removed needs: CI labels Aug 9, 2018

@cmonr cmonr merged commit 7bcbb78 into ARMmbed:master Aug 9, 2018

14 checks passed

AWS-CI uVisor Build & Test Success
Details
ci-morph-build build completed
Details
ci-morph-exporter build completed
Details
ci-morph-mbed2-build build completed
Details
ci-morph-test test completed
Details
continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
travis-ci/astyle Passed, 566 files
Details
travis-ci/docs Local docs testing has passed
Details
travis-ci/events Passed, runtime is 9825 cycles (+759 cycles)
Details
travis-ci/gitattributestest Local gitattributestest testing has passed
Details
travis-ci/licence_check Local licence_check testing has passed
Details
travis-ci/littlefs Passed, code size is 9960B (+0.00%)
Details
travis-ci/tools-py2.7 Local tools-py2.7 testing has passed
Details

@0xc0170 0xc0170 removed the ready for merge label Aug 9, 2018

@davidsaada davidsaada deleted the davidsaada:david_fix_arm_linker_script_renesas_realtek branch Aug 22, 2018

pan- pushed a commit to pan-/mbed that referenced this pull request Aug 22, 2018

Merge pull request ARMmbed#7729 from davidsaada/david_fix_arm_linker_…
…script_renesas_realtek

Rename text region in ARM linker file for Renesas & Realtek boards
@@ -55,7 +55,7 @@ LR_TCM 0x1FFF0000 0x10000 {
}
}
LR_DRAM 0x30000000 0x200000 {
LR_IROM1 0x30000000 0x200000 {

This comment has been minimized.

@M-ichae-l

M-ichae-l Sep 27, 2018

Contributor

These two regions (LR_DRAM & ER_IRAM) had re-named as one region (LR_IROM1). Are there any reasons? LR_DRAM is actually not a region that only has text. I wonder the name changes may cause further issues.

This comment has been minimized.

@cmonr

This comment has been minimized.

@M-ichae-l

M-ichae-l Nov 15, 2018

Contributor

Any suggestions?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment