New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Timeout tests : unstable result #7738

Merged
merged 1 commit into from Aug 13, 2018

Conversation

Projects
None yet
5 participants
@jeromecoutant
Contributor

jeromecoutant commented Aug 9, 2018

Description

lp_timeout test is not 100% OK for all iterations.

RTX waits, such as sem.wait(N+1), delays for between N and N+1 cycles.

As lp_ticker is not so accurate as us_ticker, delay can be also variable around N depending on used clock.

So sometimes, in lp_timeout test, semaphore wait is expiring just before the lp_timeout, and test becomes fail.
Proposition is then to use sem.wait(N+2).
Test result becomes now 100% OK.

Thx

Pull request type

[x] Fix
[ ] Refactor
[ ] Target update
[ ] Feature
[ ] Breaking change
Timeout tests : unstable result
RTX waits, such as sem.wait(N), delays for between N-1 and N cycles.
As lp_ticker is not so accurate as us_ticker,
sometines, wait is expiring just before the lp_timeout.

@0xc0170 0xc0170 requested a review from fkjagodzinski Aug 9, 2018

@0xc0170 0xc0170 requested a review from ARMmbed/mbed-os-hal Aug 9, 2018

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Aug 9, 2018

@fkjagodzinski

@jeromecoutant, thanks for the fix!

@0xc0170 0xc0170 added needs: CI and removed needs: review labels Aug 10, 2018

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Aug 10, 2018

/morph build

@mbed-ci

This comment has been minimized.

mbed-ci commented Aug 10, 2018

Build : SUCCESS

Build number : 2774
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/7738/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build
/morph mbed2-build

@mbed-ci

This comment has been minimized.

@mbed-ci

This comment has been minimized.

@cmonr

This comment has been minimized.

Contributor

cmonr commented Aug 13, 2018

/morph test

@mbed-ci

This comment has been minimized.

@cmonr cmonr merged commit 8b47f9e into ARMmbed:master Aug 13, 2018

14 checks passed

AWS-CI uVisor Build & Test Success
Details
ci-morph-build build completed
Details
ci-morph-exporter build completed
Details
ci-morph-mbed2-build build completed
Details
ci-morph-test test completed
Details
continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
travis-ci/astyle Passed, 568 files
Details
travis-ci/docs Local docs testing has passed
Details
travis-ci/events Passed, runtime is 9793 cycles (+529 cycles)
Details
travis-ci/gitattributestest Local gitattributestest testing has passed
Details
travis-ci/licence_check Local licence_check testing has passed
Details
travis-ci/littlefs Passed, code size is 9960B (+0.00%)
Details
travis-ci/tools-py2.7 Local tools-py2.7 testing has passed
Details

@0xc0170 0xc0170 removed the needs: CI label Aug 13, 2018

@jeromecoutant jeromecoutant deleted the jeromecoutant:PR_WAITSEM branch Aug 14, 2018

pan- pushed a commit to pan-/mbed that referenced this pull request Aug 22, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment