New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests-mbed_hal-common_tickers: disable ticker free test cases. #7741

Merged
merged 2 commits into from Aug 16, 2018

Conversation

Projects
None yet
5 participants
@mprse
Member

mprse commented Aug 9, 2018

Description

Resolves #7724.

Ticker free tests have been disabled since ticker free function has been implemented only for CI boards.
Implementation for the remaining platforms will be done on feature branch feature-hal-ticker-free.

Pull request type

[X] Fix
[ ] Refactor
[ ] Target update
[ ] Feature
[ ] Breaking change
@0xc0170

I would rather have this completely removed (partial revert) than #if 0 . This will be on the feature branch and comes in once its widely adopted.

tests-mbed_hal-common_tickers: disable ticker free test cases.
This is solution to issue #7724.

Ticker free tests have been removed since ticker free function has been implemented only for CI boards.
Implementation for the remaining platforms will be done on feature branch feature-hal-ticker-free.

@mprse mprse force-pushed the mprse:disable_ticker_free_tests branch from 8b0c6f9 to 20f3d87 Aug 9, 2018

@mprse

This comment has been minimized.

Member

mprse commented Aug 9, 2018

Fixed as suggested.

@0xc0170

0xc0170 approved these changes Aug 9, 2018

@0xc0170 0xc0170 requested a review from ARMmbed/mbed-os-hal Aug 9, 2018

@cmonr

This comment has been minimized.

Contributor

cmonr commented Aug 14, 2018

@mprse Once the Travis docs issue is resolved, we can start CI.

@cmonr cmonr added needs: work and removed needs: review labels Aug 14, 2018

@mprse

This comment has been minimized.

Member

mprse commented Aug 14, 2018

Removed requirements for ticker free function. This should solve the problem.

@cmonr

This comment has been minimized.

Contributor

cmonr commented Aug 14, 2018

/morph build

@mbed-ci

This comment has been minimized.

mbed-ci commented Aug 14, 2018

Build : SUCCESS

Build number : 2813
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/7741/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build
/morph mbed2-build

@mbed-ci

This comment has been minimized.

@mbed-ci

This comment has been minimized.

@cmonr cmonr added ready for merge and removed needs: CI labels Aug 16, 2018

@cmonr cmonr merged commit 3795d39 into ARMmbed:master Aug 16, 2018

14 checks passed

AWS-CI uVisor Build & Test Success
Details
ci-morph-build build completed
Details
ci-morph-exporter build completed
Details
ci-morph-mbed2-build build completed
Details
ci-morph-test test completed
Details
continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
travis-ci/astyle Passed, 583 files
Details
travis-ci/docs Local docs testing has passed
Details
travis-ci/events Passed, runtime is 10419 cycles (-135 cycles)
Details
travis-ci/gitattributestest Local gitattributestest testing has passed
Details
travis-ci/licence_check Local licence_check testing has passed
Details
travis-ci/littlefs Passed, code size is 9960B (+0.00%)
Details
travis-ci/tools-py2.7 Local tools-py2.7 testing has passed
Details

pan- pushed a commit to pan-/mbed that referenced this pull request Aug 22, 2018

Merge pull request ARMmbed#7741 from mprse/disable_ticker_free_tests
tests-mbed_hal-common_tickers: disable ticker free test cases.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment