New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Move BlockDevice classes inside mbed namespace" #7757

Merged
merged 1 commit into from Aug 13, 2018

Conversation

Projects
None yet
6 participants
@0xc0170
Member

0xc0170 commented Aug 10, 2018

Reverts #7663

don't take this as final solution to this problem. This is to trigger discussion how to and find a solution to this issue we are having now. Firstly, it looked like a small cosmetic change we could just minimize breakages... It was a good fix (yes should be in the namespace in first place).

See https://github.com/ARMmbed/mbed-cloud-client-example - this example breaks to compile with current master. There's heap.cpp (in one of its dependencies) file that includes HeapBlockDevice and use the object of the same name. Fails to build as there is no HeapBlockDevice (it is in mbed namespace now on master). We could fix it by adding namespace mbed::HeapBlockDevice but only for master or >= 5.10 version (5.9.x or prior would fail). See ARMmbed/storage-selector#40 - fix for storage selector.

I am not in favor of that migration path (if version <5.10, do not use mbed namespace, else add it). One way could be to add mbed.h include to the storage selector (just because it has using there) - there's PR 38 that is going that direction.

This should be resolved asap as our current master is breaking for some.

@0xc0170 0xc0170 requested review from pan-, geky, deepikabhavnani and ARMmbed/mbed-os-maintainers Aug 10, 2018

@geky

geky approved these changes Aug 10, 2018

@pan-

pan- approved these changes Aug 13, 2018

@cmonr

This comment has been minimized.

Contributor

cmonr commented Aug 13, 2018

Alright, let's get this going.

/morph build

@cmonr cmonr added needs: CI and removed needs: review labels Aug 13, 2018

@cmonr

cmonr approved these changes Aug 13, 2018

@mbed-ci

This comment has been minimized.

mbed-ci commented Aug 13, 2018

Build : SUCCESS

Build number : 2780
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/7757/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build
/morph mbed2-build

@mbed-ci

This comment has been minimized.

@mbed-ci

This comment has been minimized.

@cmonr

This comment has been minimized.

Contributor

cmonr commented Aug 13, 2018

/morph test

@mbed-ci

This comment has been minimized.

@cmonr cmonr merged commit 63e4ea7 into master Aug 13, 2018

15 checks passed

AWS-CI uVisor Build & Test Success
Details
ci-morph-build build completed
Details
ci-morph-exporter build completed
Details
ci-morph-mbed2-build build completed
Details
ci-morph-test test completed
Details
continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
travis-ci/astyle Passed, 568 files
Details
travis-ci/docs Local docs testing has passed
Details
travis-ci/events Passed, runtime is 9944 cycles (-120 cycles)
Details
travis-ci/gitattributestest Local gitattributestest testing has passed
Details
travis-ci/licence_check Local licence_check testing has passed
Details
travis-ci/littlefs Passed, code size is 9960B (+0.00%)
Details
travis-ci/tools-py2.7 Local tools-py2.7 testing has passed
Details

@0xc0170 0xc0170 removed the needs: CI label Aug 13, 2018

pan- pushed a commit to pan-/mbed that referenced this pull request Aug 22, 2018

Merge pull request ARMmbed#7757 from ARMmbed/revert-7663-namespace_bd…
…_update

Revert "Move BlockDevice classes inside mbed namespace"

@cmonr cmonr deleted the revert-7663-namespace_bd_update branch Sep 26, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment