New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modified Jenkinsfile into one-liner format. #7772

Merged
merged 2 commits into from Aug 22, 2018

Conversation

Projects
None yet
5 participants
@timurh01
Contributor

timurh01 commented Aug 13, 2018

Description

@OPpuolitaival
Jenkinsfile refactoring into one-liner format in order to use improved internal Jenkins scripting.

Pull request type

[ ] Fix
[ x ] Refactor
[ ] Target update
[ ] Feature
[ ] Breaking change
@OPpuolitaival

This comment has been minimized.

Contributor

OPpuolitaival commented Aug 13, 2018

Looks good

@cmonr cmonr self-requested a review Aug 13, 2018

@cmonr cmonr added the needs: review label Aug 13, 2018

@cmonr cmonr requested a review from studavekar Aug 13, 2018

@cmonr

This comment has been minimized.

Contributor

cmonr commented Aug 13, 2018

@ARMmbed/mbed-os-test I've been wondering. What does this file do, and where is it used?

What does mbed.run_job() call, and is it in the Mbed OS repo, or somewhere else?

@timurh01

This comment has been minimized.

Contributor

timurh01 commented Aug 14, 2018

Mbed-OS Jenkins CI runs command from Jenkinsfile, and that triggers Jenkins test jobs to run. Jenkins is used to run tests that cannot be shared publicly. Script framework, that is called by this mbed.run_job(), is located in repo mbed-os-ci/vars (private repo). And this frame is already built that way, that old format Jenkinsfile is actually calling mbed.run_job() command.
More info from @OPpuolitaival

@0xc0170

While we are doing this update, as @cmonr asked about it. Can we add a description to this file what it does, why it is here.

// This is internal file for internal jenkins (something similar)
@OPpuolitaival

This comment has been minimized.

Contributor

OPpuolitaival commented Aug 20, 2018

@0xc0170 good point

@timurh01

This comment has been minimized.

Contributor

timurh01 commented Aug 20, 2018

Comment inside Jenkinsfile updated.

@cmonr

cmonr approved these changes Aug 21, 2018

@cmonr cmonr added needs: CI and removed needs: review labels Aug 21, 2018

@cmonr

This comment has been minimized.

Contributor

cmonr commented Aug 21, 2018

/morph build

@OPpuolitaival

This comment has been minimized.

Contributor

OPpuolitaival commented Aug 21, 2018

@cmonr morph build need to retriggering. There was jenkins internal failure

@mbed-ci

This comment has been minimized.

mbed-ci commented Aug 21, 2018

Build : SUCCESS

Build number : 2851
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/7772/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build
/morph mbed2-build

@mbed-ci

This comment has been minimized.

@mbed-ci

This comment has been minimized.

@0xc0170 0xc0170 added ready for merge and removed needs: CI labels Aug 22, 2018

@0xc0170 0xc0170 merged commit b373b13 into ARMmbed:master Aug 22, 2018

15 checks passed

AWS-CI uVisor Build & Test Success
Details
ci-morph-build build completed
Details
ci-morph-exporter build completed
Details
ci-morph-mbed2-build build completed
Details
ci-morph-test test completed , RTOS ROM(+0.0%) RAM(+0.0%)
Details
continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
jenkins-ci/cloud_client_smoke_test Test job was successful
Details
travis-ci/astyle Passed, 584 files
Details
travis-ci/docs Local docs testing has passed
Details
travis-ci/events Passed, runtime is 9923 cycles (-512 cycles)
Details
travis-ci/gitattributestest Local gitattributestest testing has passed
Details
travis-ci/licence_check Local licence_check testing has passed
Details
travis-ci/littlefs Passed, code size is 8372B (+0.00%)
Details
travis-ci/tools-py2.7 Local tools-py2.7 testing has passed
Details

pan- pushed a commit to pan-/mbed that referenced this pull request Aug 22, 2018

Merge pull request ARMmbed#7772 from timurh01/jenkinsfile_refactor
Modified Jenkinsfile into one-liner format.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment