New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moved ASYNCHRONOUS_DNS_SIMULTANEOUS_REPEAT under mbed extended tests #7786

Merged
merged 1 commit into from Aug 16, 2018

Conversation

Projects
None yet
5 participants
@mikaleppanen
Contributor

mikaleppanen commented Aug 14, 2018

Description

Test is giving problems in some networks. Could be that DNS server is regarding repeated DNS enquiries on the test to be caused by malfunctioning device.

Pull request type

[X] Fix
[ ] Refactor
[ ] Target update
[ ] Feature
[ ] Breaking change
Moved ASYNCHRONOUS_DNS_SIMULTANEOUS_REPEAT under mbed extended tests
Test is giving problems in some networks. Could be that DNS server
is regarding repeated DNS enquiries on the test to be caused by
malfunctioning device.
@adbridge

How do we know that the asynchronous DNS tests will now be run? When are MBED_EXTENDED_TESTS actually run ?

@adbridge adbridge requested a review from cmonr Aug 14, 2018

@mikaleppanen

This comment has been minimized.

Contributor

mikaleppanen commented Aug 14, 2018

@adbridge Tests flagged with MBED_EXTENDED_TESTS are build/run once a day against latest mbed-os master in the ip-core Jenkins build system.

@cmonr

cmonr approved these changes Aug 14, 2018

Thank you for the quick response!

@cmonr

This comment has been minimized.

Contributor

cmonr commented Aug 14, 2018

@adbridge Looks like there are some other tests already in the repo that use this compiler flag.

@cmonr

This comment has been minimized.

Contributor

cmonr commented Aug 14, 2018

/morph build

@adbridge

This comment has been minimized.

Contributor

adbridge commented Aug 14, 2018

@mikaleppanen So have we just effectively removed some testing from pull requests ? ie we won't now be able to detect issues with asynch dns until after a PR has been merged to master potentially ?

@mikaleppanen

This comment has been minimized.

Contributor

mikaleppanen commented Aug 14, 2018

@adbridge The other asynchronous DNS tests will verify most of the functionality. So I think it is not problem if this particular test is not run for all pull requests.

@mbed-ci

This comment has been minimized.

mbed-ci commented Aug 14, 2018

Build : SUCCESS

Build number : 2809
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/7786/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build
/morph mbed2-build

@mbed-ci

This comment has been minimized.

@mbed-ci

This comment has been minimized.

@cmonr

This comment has been minimized.

Contributor

cmonr commented Aug 16, 2018

/morph test

@mbed-ci

This comment has been minimized.

@cmonr cmonr added ready for merge and removed needs: CI labels Aug 16, 2018

@cmonr cmonr merged commit 3c25b96 into ARMmbed:master Aug 16, 2018

14 checks passed

AWS-CI uVisor Build & Test Success
Details
ci-morph-build build completed
Details
ci-morph-exporter build completed
Details
ci-morph-mbed2-build build completed
Details
ci-morph-test test completed , RTOS ROM(+0.0%) RAM(+0.0%)
Details
continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
travis-ci/astyle Passed, 583 files
Details
travis-ci/docs Local docs testing has passed
Details
travis-ci/events Passed, runtime is 10258 cycles (-296 cycles)
Details
travis-ci/gitattributestest Local gitattributestest testing has passed
Details
travis-ci/licence_check Local licence_check testing has passed
Details
travis-ci/littlefs Passed, code size is 9960B (+0.00%)
Details
travis-ci/tools-py2.7 Local tools-py2.7 testing has passed
Details

@mikaleppanen mikaleppanen deleted the mikaleppanen:dns_repeat_to_ext branch Aug 17, 2018

pan- pushed a commit to pan-/mbed that referenced this pull request Aug 22, 2018

Merge pull request ARMmbed#7786 from mikaleppanen/dns_repeat_to_ext
Moved ASYNCHRONOUS_DNS_SIMULTANEOUS_REPEAT under mbed extended tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment