New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

STM32 LPTICKER : RTC wake up timer is reset before setting a new one #7790

Merged
merged 3 commits into from Aug 22, 2018

Conversation

Projects
None yet
7 participants
@jeromecoutant
Contributor

jeromecoutant commented Aug 14, 2018

Description

Affected targets : targets supporting LPTICKER and using RTC wake up timer.

Patch:

  • timer is now reset before setting a new value
  • LPTICKER_DELAY_TICKS is decreased to only 1 for targets with low frequency system clock
  • LPTICKER_DELAY_TICKS seems to be no more needed for targets with high frequency system clock

NB:

  • LPTICKER_DELAY_TICKS is not changed for targets using LPTIM

@c1728p9 @LMESTM

Tests

Patch tested with ARM tool chain with 1 board per STM32 family

Tests with TICKLESS look OK with NUCLEO_F401RE

Pull request type

[X] Fix
[ ] Refactor
[ ] Target update
[ ] Feature
[ ] Breaking change

jeromecoutant added some commits Aug 14, 2018

STM32 : update LPTICKER_DELAY_TICKS value
- decreased to 1 for low freq targets
- removed for high freq targets
- not changed for targets with LPTIM
@@ -270,7 +270,7 @@ void rtc_write(time_t t)
#if DEVICE_LPTICKER && !MBED_CONF_TARGET_LPTICKER_LPTIM
/* Need to update LP_continuous_time value before new RTC time */
uint32_t current_lp_time = rtc_read_lp();
rtc_read_lp();

This comment has been minimized.

@adbridge

adbridge Aug 15, 2018

Contributor

Might be nice to (void) the return of this function to show that you are purposefully ignoring the return value ?

This comment has been minimized.

@jeromecoutant

jeromecoutant Aug 16, 2018

Contributor

In this very specific case, we don't need to get the return value.
Function is called because global variable LP_continuous_time is updated there.

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Aug 20, 2018

/morph build

@0xc0170 0xc0170 added needs: CI and removed needs: review labels Aug 20, 2018

@mbed-ci

This comment has been minimized.

mbed-ci commented Aug 20, 2018

Build : SUCCESS

Build number : 2841
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/7790/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build
/morph mbed2-build

@mbed-ci

This comment has been minimized.

@mbed-ci

This comment has been minimized.

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Aug 21, 2018

/morph test
/morph uvisor-test
/morph export-build

@mbed-ci

This comment has been minimized.

@mbed-ci

This comment has been minimized.

@cmonr cmonr added ready for merge and removed needs: CI labels Aug 22, 2018

@0xc0170 0xc0170 merged commit d28d13c into ARMmbed:master Aug 22, 2018

15 checks passed

AWS-CI uVisor Build & Test Success
Details
ci-morph-build build completed
Details
ci-morph-exporter build completed
Details
ci-morph-mbed2-build build completed
Details
ci-morph-test test completed , RTOS ROM(+0.0%) RAM(+0.0%)
Details
continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
jenkins-ci/cloud_client_smoke_test Test job was successful
Details
travis-ci/astyle Passed, 583 files
Details
travis-ci/docs Local docs testing has passed
Details
travis-ci/events Passed, runtime is 10073 cycles (-481 cycles)
Details
travis-ci/gitattributestest Local gitattributestest testing has passed
Details
travis-ci/licence_check Local licence_check testing has passed
Details
travis-ci/littlefs Passed, code size is 9960B (+0.00%)
Details
travis-ci/tools-py2.7 Local tools-py2.7 testing has passed
Details

pan- pushed a commit to pan-/mbed that referenced this pull request Aug 22, 2018

Merge pull request ARMmbed#7790 from jeromecoutant/PR_LPTICKER_RTC
STM32 LPTICKER : RTC wake up timer is reset before setting a new one

@jeromecoutant jeromecoutant deleted the jeromecoutant:PR_LPTICKER_RTC branch Sep 4, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment