New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow ThreadInterface::device_eui64_get() before connect() #7818

Merged
merged 2 commits into from Aug 28, 2018

Conversation

Projects
None yet
6 participants
@kjbracey-arm
Contributor

kjbracey-arm commented Aug 17, 2018

Description

Perform necessary driver initialisation so that we can read the EUI-64 before connecting.

Fixes #7391.

Pull request type

[ ] Fix
[X] Refactor
[ ] Target update
[ ] Functionality change
[ ] Breaking change

Marked as refactor as it's a non-trivial initialisation rework, and it wasn't necessarily intended to permit this ordering originally, although it makes sense.

kjbracey-arm added some commits Aug 17, 2018

Streamline Nanostack interface initialisation
Can unify quite a log of the setup here, and that would be useful to
allow initialisation other than in "connect".
Allow ThreadInterface::device_eui64_get() before connect()
Perform necessary driver initialisation so that we can read
the EUI-64 before connecting.

Fixes #7391.

@kjbracey-arm kjbracey-arm changed the title from Eui64 get early to Allow ThreadInterface::device_eui64_get() before connect() Aug 17, 2018

@cmonr cmonr requested review from SeppoTakalo and KariHaapalehto Aug 17, 2018

@kjbracey-arm kjbracey-arm requested a review from artokin Aug 21, 2018

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Aug 26, 2018

/morph build

@mbed-ci

This comment has been minimized.

mbed-ci commented Aug 26, 2018

Build : SUCCESS

Build number : 2909
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/7818/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build
/morph mbed2-build

@mbed-ci

This comment has been minimized.

@mbed-ci

This comment has been minimized.

@cmonr

This comment has been minimized.

Contributor

cmonr commented Aug 27, 2018

/morph uvisor-test

@cmonr

This comment has been minimized.

Contributor

cmonr commented Aug 27, 2018

@ARMmbed/mbed-os-maintainers Since uVisor is being removed in 5.10, and this PR is only targeting 5.10, anyone object to bringing it in even though the PR is not all green?

I've already removed uVisor as a branch chcek, but if the test ran in a PR before it was removed, it'll still show up in the check list.

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Aug 27, 2018

I've already removed uVisor as a branch chcek, but if the test ran in a PR before it was removed, it'll still show up in the check list.

We need to remove uvisor trigger from build comment (manual driver if needed for now). And this check, will be fixed.

@cmonr

This comment has been minimized.

Contributor

cmonr commented Aug 27, 2018

@SeppoTakalo @KariHaapalehto Would y'all mind taking a look at this? It's ready for merge otherwise.

@0xc0170 0xc0170 merged commit b2a0551 into ARMmbed:master Aug 28, 2018

15 checks passed

AWS-CI uVisor Build & Test Success
Details
ci-morph-build build completed
Details
ci-morph-exporter build completed
Details
ci-morph-mbed2-build build completed
Details
ci-morph-test test completed , RTOS ROM(+0.0%) RAM(+0.0%)
Details
continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
jenkins-ci/cloud_client_smoke_test Test job was successful
Details
travis-ci/astyle Passed, 584 files
Details
travis-ci/docs Local docs testing has passed
Details
travis-ci/events Passed, runtime is 9990 cycles (+87 cycles)
Details
travis-ci/gitattributestest Local gitattributestest testing has passed
Details
travis-ci/licence_check Local licence_check testing has passed
Details
travis-ci/littlefs Passed, code size is 8372B (+0.00%)
Details
travis-ci/tools-py2.7 Local tools-py2.7 testing has passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment