New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MIMXRT1050_EVK: Update the I2C driver #7823

Merged
merged 1 commit into from Aug 21, 2018

Conversation

Projects
None yet
5 participants
@mmahadevan108
Contributor

mmahadevan108 commented Aug 17, 2018

Description

  1. Remove the repeated_start flag and code as this is not needed
    for the LPI2C module
  2. Enable the SION bit on the I2C pins
  3. Enable 22K Pullup option of the I2C pins
  4. Update the 0 byte write implementation to ensure the START command gets flushed out of the FIFO

Pull request type

[X] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Breaking change
MIMXRT1050_EVK: Update the I2C driver
1. Remove the repeated_start flag and code as this is not needed
   for the LPI2C module
2. Enable the SION bit on the I2C pins
3. Enable 22K Pullup option of the I2C pins
4. Update the 0 byte write implementation to ensure the START
   command gets flushed out of the FIFO

Signed-off-by: Mahesh Mahadevan <mahesh.mahadevan@nxp.com>
@mmahadevan108

This comment has been minimized.

Contributor

mmahadevan108 commented Aug 17, 2018

@cmonr

cmonr approved these changes Aug 17, 2018

Looks fine to me, but is this removing repeated start support?

@cmonr

This comment has been minimized.

Contributor

cmonr commented Aug 17, 2018

Nvm on the comment question. Commit message says it all!

/morph build

@mbed-ci

This comment has been minimized.

mbed-ci commented Aug 17, 2018

Build : SUCCESS

Build number : 2833
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/7823/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build
/morph mbed2-build

@mbed-ci

This comment has been minimized.

@mbed-ci

This comment has been minimized.

@NirSonnenschein

This comment has been minimized.

Contributor

NirSonnenschein commented Aug 21, 2018

/morph uvisor-test

@cmonr cmonr merged commit 4b5c6c8 into ARMmbed:master Aug 21, 2018

15 checks passed

AWS-CI uVisor Build & Test Success
Details
ci-morph-build build completed
Details
ci-morph-exporter build completed
Details
ci-morph-mbed2-build build completed
Details
ci-morph-test test completed , RTOS ROM(+0.0%) RAM(+0.0%)
Details
continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
jenkins-ci/cloud_client_smoke_test Test job was successful
Details
travis-ci/astyle Passed, 584 files
Details
travis-ci/docs Local docs testing has passed
Details
travis-ci/events Passed, runtime is 10030 cycles (+66 cycles)
Details
travis-ci/gitattributestest Local gitattributestest testing has passed
Details
travis-ci/licence_check Local licence_check testing has passed
Details
travis-ci/littlefs Passed, code size is 8372B (+0.00%)
Details
travis-ci/tools-py2.7 Local tools-py2.7 testing has passed
Details

@mmahadevan108 mmahadevan108 deleted the NXPmicro:MIMXRT1050_Fix_I2C branch Aug 21, 2018

pan- pushed a commit to pan-/mbed that referenced this pull request Aug 22, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment