New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nanostack: Fix return code for unsupported socket options #7832

Merged
merged 1 commit into from Aug 21, 2018

Conversation

Projects
None yet
5 participants
@juhaylinen
Contributor

juhaylinen commented Aug 20, 2018

Description

Return NSAPI_ERROR_UNSUPPORTED if socket option is not supported

Pull request type

[X] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Breaking change

@0xc0170 0xc0170 requested a review from ARMmbed/mbed-os-ipcore Aug 20, 2018

@@ -816,6 +816,10 @@ nsapi_error_t Nanostack::getsockopt(void *handle, int level, int optname, void *
NanostackLockGuard lock;
if (level == NSAPI_SOCKET) {

This comment has been minimized.

@kjbracey-arm

kjbracey-arm Aug 20, 2018

Contributor

I think this could be done by better translation of the return code from Nanostack below, same for socket_setsockopt above). As I recall, it properly distinguishes two codes (-2 and -3?) for "bad parameter" and "unsupported option".

If you had that translation correct below, then you wouldn't need this extra clause here.

@juhaylinen juhaylinen force-pushed the juhaylinen:fix-nanostack-setsockoptions branch from 19f05a6 to b8a7e25 Aug 20, 2018

@juhaylinen

This comment has been minimized.

Contributor

juhaylinen commented Aug 20, 2018

@kjbracey-arm Updated the commit according to your feedback

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Aug 20, 2018

/morph build

@0xc0170 0xc0170 added needs: CI and removed needs: review labels Aug 20, 2018

@mbed-ci

This comment has been minimized.

mbed-ci commented Aug 20, 2018

Build : SUCCESS

Build number : 2845
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/7832/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build
/morph mbed2-build

@mbed-ci

This comment has been minimized.

@mbed-ci

This comment has been minimized.

@0xc0170 0xc0170 added ready for merge and removed needs: CI labels Aug 21, 2018

@cmonr cmonr merged commit d9367f8 into ARMmbed:master Aug 21, 2018

15 checks passed

AWS-CI uVisor Build & Test Success
Details
ci-morph-build build completed
Details
ci-morph-exporter build completed
Details
ci-morph-mbed2-build build completed
Details
ci-morph-test test completed , RTOS ROM(+0.0%) RAM(+0.0%)
Details
continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
jenkins-ci/cloud_client_smoke_test Test job was successful
Details
travis-ci/astyle Passed, 584 files
Details
travis-ci/docs Local docs testing has passed
Details
travis-ci/events Passed, runtime is 10320 cycles (-115 cycles)
Details
travis-ci/gitattributestest Local gitattributestest testing has passed
Details
travis-ci/licence_check Local licence_check testing has passed
Details
travis-ci/littlefs Passed, code size is 8372B (+0.00%)
Details
travis-ci/tools-py2.7 Local tools-py2.7 testing has passed
Details

pan- pushed a commit to pan-/mbed that referenced this pull request Aug 22, 2018

Merge pull request ARMmbed#7832 from juhaylinen/fix-nanostack-setsock…
…options

Nanostack: Fix return code for unsupported socket options
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment