New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WISE_1570 greentea tests #7840

Merged
merged 4 commits into from Aug 24, 2018

Conversation

Projects
None yet
7 participants
@mirelachirica
Contributor

mirelachirica commented Aug 21, 2018

Description

Fixing greentea tests to work with WISE_1570 modem:
https://jira.arm.com/browse/IOTCELL-1142

Pull request type

[ x] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Breaking change
@0xc0170

Changes looks fine to me.

Fixes looks straightforward but at least one there required implementation change (file features/cellular/framework/AT/AT_CellularNetwork.cpp) and does not contain any information how is it fixing it - I would say it should "how it is fixed" at least one sentence there in the commit message

@0xc0170 0xc0170 requested a review from ARMmbed/mbed-os-wan Aug 21, 2018

@AnttiKauppila

LGTM

@AnttiKauppila

This comment has been minimized.

Contributor

AnttiKauppila commented Aug 21, 2018

@mirelachirica Please update the commit message as Nir suggested

@mirelachirica mirelachirica force-pushed the mirelachirica:wise_1570_greentea_tests branch from cacde2b to 9ef2d0d Aug 22, 2018

@mirelachirica

This comment has been minimized.

Contributor

mirelachirica commented Aug 22, 2018

I made a separate commit and also limited the original change to LTE mode only, because only in that mode the last active context shouldnt be deactivated.

@0xc0170 0xc0170 added needs: CI and removed needs: review labels Aug 22, 2018

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Aug 22, 2018

/morph build

@mbed-ci

This comment has been minimized.

mbed-ci commented Aug 22, 2018

Build : SUCCESS

Build number : 2864
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/7840/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build
/morph mbed2-build

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Aug 22, 2018

/morph mbed2-build

@mbed-ci

This comment has been minimized.

@mbed-ci

This comment has been minimized.

@cmonr

This comment has been minimized.

Contributor

cmonr commented Aug 23, 2018

/morph export-build

@mbed-ci

This comment has been minimized.

@0xc0170 0xc0170 merged commit 582b414 into ARMmbed:master Aug 24, 2018

15 checks passed

AWS-CI uVisor Build & Test Success
Details
ci-morph-build build completed
Details
ci-morph-exporter build completed
Details
ci-morph-mbed2-build build completed
Details
ci-morph-test test completed , RTOS ROM(+0.0%) RAM(+0.0%)
Details
continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
jenkins-ci/cloud_client_smoke_test Test job was successful
Details
travis-ci/astyle Passed, 585 files
Details
travis-ci/docs Local docs testing has passed
Details
travis-ci/events Passed, runtime is 9121 cycles (-16 cycles)
Details
travis-ci/gitattributestest Local gitattributestest testing has passed
Details
travis-ci/licence_check Local licence_check testing has passed
Details
travis-ci/littlefs Passed, code size is 8372B (+0.00%)
Details
travis-ci/tools-py2.7 Local tools-py2.7 testing has passed
Details

pan- pushed a commit to pan-/mbed that referenced this pull request Aug 29, 2018

@adbridge

This comment has been minimized.

Contributor

adbridge commented Sep 7, 2018

Based on top of changes added for 5.10 only and already present in 5.10

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment