New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Message ID in CAN constructor needs to be unsigned #7848

Merged
merged 1 commit into from Aug 27, 2018

Conversation

Projects
None yet
5 participants
@aashishc1988
Contributor

aashishc1988 commented Aug 21, 2018

Change data type of MessageID in CAN constructor to unsigned from int to avoid unnecessary implicit conversion from int to unsigned.

Issue: #7444

[x] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Breaking change
@cmonr

cmonr approved these changes Aug 22, 2018

@cmonr

This comment has been minimized.

Contributor

cmonr commented Aug 22, 2018

/morph build

@mbed-ci

This comment has been minimized.

mbed-ci commented Aug 22, 2018

Build : SUCCESS

Build number : 2857
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/7848/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build
/morph mbed2-build

@mbed-ci

This comment has been minimized.

@mbed-ci

This comment has been minimized.

@NirSonnenschein

This comment has been minimized.

Contributor

NirSonnenschein commented Aug 26, 2018

/morph test

1 similar comment
@cmonr

This comment has been minimized.

Contributor

cmonr commented Aug 27, 2018

/morph test

@mbed-ci

This comment has been minimized.

@NirSonnenschein

This comment has been minimized.

Contributor

NirSonnenschein commented Aug 27, 2018

@cmonr CI passed but only one review (yours), does this count as ready to merge?

@cmonr

This comment has been minimized.

Contributor

cmonr commented Aug 27, 2018

@NirSonnenschein It's a small bug update, so it should be fine.
BUT since the constructor changes, it should go to the feature release.

@cmonr cmonr merged commit e2409bf into ARMmbed:master Aug 27, 2018

15 checks passed

AWS-CI uVisor Build & Test Success
Details
ci-morph-build build completed
Details
ci-morph-exporter build completed
Details
ci-morph-mbed2-build build completed
Details
ci-morph-test test completed , RTOS ROM(+0.0%) RAM(+0.0%)
Details
continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
jenkins-ci/cloud_client_smoke_test Test job was successful
Details
travis-ci/astyle Passed, 584 files
Details
travis-ci/docs Local docs testing has passed
Details
travis-ci/events Passed, runtime is 9889 cycles (+704 cycles)
Details
travis-ci/gitattributestest Local gitattributestest testing has passed
Details
travis-ci/licence_check Local licence_check testing has passed
Details
travis-ci/littlefs Passed, code size is 8372B (+0.00%)
Details
travis-ci/tools-py2.7 Local tools-py2.7 testing has passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment