New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Realtek: fix gpio is connected #7856

Merged
merged 1 commit into from Sep 18, 2018

Conversation

Projects
None yet
4 participants
@fredlee12001
Contributor

fredlee12001 commented Aug 22, 2018

Description

Met linking issue when try to compile the mbed-cloud-client-example for REALTEK_RTL8195AM platform using ARM toolchain.

mbed compile -t ARM -m REALTEK_RTL8195AM
.....
.....
Link: mbed-cloud-client-example
Error: L6218E: Undefined symbol gpio_is_connected (referred from ../BUILD/REALTEK_RTL8195AM/ARM/storage-selector/dataflash-driver/DataFlashBlockDevice.o).
Finished: 0 information, 0 warning and 1 error messages.
[ERROR] Error: L6218E: Undefined symbol gpio_is_connected (referred from ../BUILD/REALTEK_RTL8195AM/ARM/storage-selector/dataflash-driver/DataFlashBlockDevice.o).
Finished: 0 information, 0 warning and 1 error messages.

[mbed] ERROR: "c:\python27\python.exe" returned error code 1.

Pull request type

[X ] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Breaking change

@0xc0170 0xc0170 requested a review from ARMmbed/team-realtek Aug 22, 2018

@0xc0170 0xc0170 changed the title from Fix Link issue when compile mbed-cloud-client-example. to Realtek: fix gpio is connected Aug 22, 2018

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Aug 22, 2018

Merge pull request #1 from ARMmbed/master …

Can you rebase this instead please? (to remove this merge commit)

@0xc0170

Code looks good, just needs a rebase

@fredlee12001 fredlee12001 force-pushed the fredlee12001:master branch from 3576c84 to 9d7a112 Aug 23, 2018

@fredlee12001

This comment has been minimized.

Contributor

fredlee12001 commented Aug 23, 2018

Rebase to master instead of create PR.

@0xc0170

I noticed the style is different (the rest of file has it fine)

int gpio_is_connected(const gpio_t *obj)
{
}

{ on the new line.

Thanks for the rebase, this shall be ready for CI once fixed

@fredlee12001 fredlee12001 force-pushed the fredlee12001:master branch from 9d7a112 to 84eda27 Aug 23, 2018

@fredlee12001

This comment has been minimized.

Contributor

fredlee12001 commented Aug 23, 2018

Changed and Keep same coding style with others.

@0xc0170 0xc0170 added needs: CI and removed needs: review labels Aug 23, 2018

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Sep 17, 2018

/morph build

@mbed-ci

This comment has been minimized.

mbed-ci commented Sep 17, 2018

Build : SUCCESS

Build number : 3085
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/7856/

Triggering tests

/morph test
/morph export-build
/morph mbed2-build

@mbed-ci

This comment has been minimized.

@mbed-ci

This comment has been minimized.

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Sep 18, 2018

/morph test

@mbed-ci

This comment has been minimized.

@0xc0170 0xc0170 merged commit 7bcb066 into ARMmbed:master Sep 18, 2018

14 checks passed

ci-morph-build build completed
Details
ci-morph-exporter build completed
Details
ci-morph-mbed2-build build completed
Details
ci-morph-test test completed , RTOS ROM(+0.0%) RAM(+0.0%)
Details
continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
jenkins-ci/cloud_client_smoke_test Test job was successful
Details
travis-ci/astyle Passed, 585 files
Details
travis-ci/docs Local docs testing has passed
Details
travis-ci/events Passed, runtime is 9908 cycles (+710 cycles)
Details
travis-ci/gitattributestest Local gitattributestest testing has passed
Details
travis-ci/licence_check Local licence_check testing has passed
Details
travis-ci/littlefs Passed, code size is 8372B (+0.00%)
Details
travis-ci/tools-py2.7 Local tools-py2.7 testing has passed
Details
@0xc0170

This comment has been minimized.

Member

0xc0170 commented Sep 18, 2018

@studavekar Please review the latest test result.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment