New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing default flow control for MTB_LAIRD_BL652 #7861

Merged
merged 1 commit into from Oct 8, 2018

Conversation

Projects
None yet
6 participants
@ashok-rao
Contributor

ashok-rao commented Aug 22, 2018

Description

Flow control is enabled by default for this target that derives from nRF52. It needs to be disabled for the MTB_LAIRD_BL652 module target since this module does not need flow control enabled.

Verified with printf() messages on the serial terminal. WIth FC = "RTSCTS" (i.e. default in Mbed OS today) there are no debug messages sent over the UART to terminal.

@cmonr or @0xc0170 : Please let me know what tests would be required for this. I can attach relevant logs. Thanks.

Pull request type

[ ] Fix
[x] Refactor
[ ] Target update
[ ] Functionality change
[ ] Breaking change

@ashok-rao ashok-rao changed the title from Removing default flow control for BL652 to Removing default flow control for MTB_LAIRD_BL652 Aug 22, 2018

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Aug 23, 2018

Any test should do as would test the console uart

@cmonr cmonr added needs: work and removed needs: review labels Aug 24, 2018

@cmonr cmonr requested review from 0xc0170 and marcuschangarm Aug 24, 2018

@marcuschangarm

This comment has been minimized.

Contributor

marcuschangarm commented Oct 4, 2018

@ashok-rao
The default behavior is null so you can just remove the line completely like for the other targets that don't require flow control.

@ashok-rao

This comment has been minimized.

Contributor

ashok-rao commented Oct 5, 2018

@cmonr ..over to you..

@0xc0170

0xc0170 approved these changes Oct 5, 2018

@0xc0170 0xc0170 added needs: CI and removed needs: work labels Oct 5, 2018

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Oct 5, 2018

/morph build

@mbed-ci

This comment has been minimized.

mbed-ci commented Oct 5, 2018

Build : SUCCESS

Build number : 3255
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/7861/

Triggering tests

/morph test
/morph mbed2-build

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Oct 6, 2018

/morph export-build

@mbed-ci

This comment has been minimized.

@mbed-ci

This comment has been minimized.

@cmonr cmonr merged commit ebb0d02 into ARMmbed:master Oct 8, 2018

14 checks passed

ci-morph-build build completed
Details
ci-morph-exporter build completed
Details
ci-morph-mbed2-build build completed
Details
ci-morph-test test completed , RTOS ROM(+0 bytes) RAM(+0 bytes)
Details
continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
jenkins-ci/cloud_client_smoke_test Test job was successful
Details
travis-ci/astyle Passed, 584 files
Details
travis-ci/docs Local docs testing has passed
Details
travis-ci/events Passed, runtime is 10379 cycles (+487 cycles)
Details
travis-ci/gitattributestest Local gitattributestest testing has passed
Details
travis-ci/licence_check Local licence_check testing has passed
Details
travis-ci/littlefs Passed, code size is 8372B (+0.00%)
Details
travis-ci/tools-py2.7 Local tools-py2.7 testing has passed
Details

@cmonr cmonr removed the ready for merge label Oct 8, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment