New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests for synchronous dns #7879

Merged
merged 1 commit into from Aug 29, 2018

Conversation

Projects
None yet
5 participants
@jarlamsa
Contributor

jarlamsa commented Aug 24, 2018

Description

Add test cases for synchronous dns.

Pull request type

[ ] Fix
[ ] Refactor
[ ] Target update
[x] Functionality change
[ ] Breaking change

@0xc0170 0xc0170 requested a review from ARMmbed/mbed-os-ipcore Aug 24, 2018

@jarlamsa

This comment has been minimized.

Contributor

jarlamsa commented Aug 27, 2018

@0xc0170 Was there some issue in Travis last week, the logs look like some issues in the Travis job itself?

@jarlamsa

This comment has been minimized.

Contributor

jarlamsa commented Aug 27, 2018

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Aug 27, 2018

@0xc0170 Was there some issue in Travis last week, the logs look like some issues in the Travis job itself?

Yes, it looks fine now

@0xc0170

Looks fine to me (besides naming of the test cases being upper case - but shall be addressed by separate fix).

One change - can you review astyle travis job (one line should be fixed)

@0xc0170 0xc0170 added needs: work and removed needs: review labels Aug 27, 2018

@jarlamsa jarlamsa force-pushed the jarlamsa:synchronous_dns_tests branch 2 times, most recently from 9e4f07a to 14c0a11 Aug 27, 2018

@jarlamsa

This comment has been minimized.

Contributor

jarlamsa commented Aug 27, 2018

Done. It would be easier to notice if there is something to be done in the astyle if it would directly report that the check wasn't successful, now you basically need to separately open the logs each time to see if there is something wrong.

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Aug 27, 2018

Done. It would be easier to notice if there is something to be done in the astyle if it would directly report that the check wasn't successful, now you basically need to separately open the logs each time to see if there is something wrong.

I'll look at this, it should have reported how many files needs changing +/- , we will fix

To add some details - we are currently still cleaning up the code base. Errors in the style will come most probably in the next release (still around 500 files to be cleaned). I'll send another PR to decrease the count.

@0xc0170 0xc0170 added needs: CI and removed needs: work labels Aug 27, 2018

@jarlamsa jarlamsa force-pushed the jarlamsa:synchronous_dns_tests branch from 14c0a11 to 0c758b9 Aug 27, 2018

@jarlamsa

This comment has been minimized.

Contributor

jarlamsa commented Aug 28, 2018

@0xc0170 Can the CI be initiated for this PR?

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Aug 28, 2018

/morph build

@mbed-ci

This comment has been minimized.

mbed-ci commented Aug 28, 2018

Build : SUCCESS

Build number : 2941
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/7879/

Triggering tests

/morph test
/morph export-build
/morph mbed2-build

@mbed-ci

This comment has been minimized.

@jarlamsa

This comment has been minimized.

Contributor

jarlamsa commented Aug 29, 2018

Test was successful but I can't even see exporter being built at all. Is the CI working as expected?

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Aug 29, 2018

/morph export-build
/morph mbed2-build

@mbed-ci

This comment has been minimized.

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Aug 29, 2018

License server error (fixed now)

/morph export-build

@mbed-ci

This comment has been minimized.

@cmonr cmonr merged commit 7d871bf into ARMmbed:master Aug 29, 2018

14 checks passed

ci-morph-build build completed
Details
ci-morph-exporter build completed
Details
ci-morph-mbed2-build build completed
Details
ci-morph-test test completed , RTOS ROM(+0.0%) RAM(+0.0%)
Details
continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
jenkins-ci/cloud_client_smoke_test Test job was successful
Details
travis-ci/astyle Passed, 553 files
Details
travis-ci/docs Local docs testing has passed
Details
travis-ci/events Passed, runtime is 9144 cycles (-6 cycles)
Details
travis-ci/gitattributestest Local gitattributestest testing has passed
Details
travis-ci/licence_check Local licence_check testing has passed
Details
travis-ci/littlefs Passed, code size is 8372B (+0.00%)
Details
travis-ci/tools-py2.7 Local tools-py2.7 testing has passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment