New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused cmsis includes. #7891

Merged
merged 1 commit into from Aug 28, 2018

Conversation

Projects
None yet
7 participants
@tkem
Contributor

tkem commented Aug 25, 2018

Description

Remove unused "cmsis.h" includes from CAN and TimerEvent drivers.
AFAICS those files do not use any CMSIS functionality, and I guess code in "drivers" shouldn't use CMSIS directly, anyway.
Since this is not really a "Fix" (nothing's broken, actually), I'll go with "Refactor" as Pull request type (maybe you want to add "Cleanup" to that list).

Pull request type

[ ] Fix
[x] Refactor
[ ] Target update
[ ] Functionality change
[ ] Breaking change

@0xc0170 0xc0170 requested a review from ARMmbed/mbed-os-core Aug 27, 2018

@cmonr cmonr requested a review from c1728p9 Aug 27, 2018

@cmonr

This comment has been minimized.

Contributor

cmonr commented Aug 27, 2018

@c1728p9 Could you take a quick look at this?

@cmonr cmonr added needs: CI and removed needs: review labels Aug 27, 2018

@cmonr

This comment has been minimized.

Contributor

cmonr commented Aug 27, 2018

/morph build

@mbed-ci

This comment has been minimized.

mbed-ci commented Aug 27, 2018

Build : SUCCESS

Build number : 2931
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/7891/

Triggering tests

/morph test
/morph export-build
/morph mbed2-build

@mbed-ci

This comment has been minimized.

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Aug 28, 2018

@OPpuolitaival @studavekar Another multiple defined symbols (cleanup problem?)

/morph export-build

@mbed-ci

This comment has been minimized.

@mbed-ci

This comment has been minimized.

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Aug 28, 2018

/morph mbed2-build

@cmonr cmonr added ready for merge and removed needs: CI labels Aug 28, 2018

@cmonr cmonr merged commit 3f5cd54 into ARMmbed:master Aug 28, 2018

14 checks passed

ci-morph-build build completed
Details
ci-morph-exporter build completed
Details
ci-morph-mbed2-build build completed
Details
ci-morph-test test completed , RTOS ROM(+0.0%) RAM(+0.0%)
Details
continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
jenkins-ci/cloud_client_smoke_test Test job was successful
Details
travis-ci/astyle Passed, 587 files
Details
travis-ci/docs Local docs testing has passed
Details
travis-ci/events Passed, runtime is 9885 cycles (-17 cycles)
Details
travis-ci/gitattributestest Local gitattributestest testing has passed
Details
travis-ci/licence_check Local licence_check testing has passed
Details
travis-ci/littlefs Passed, code size is 8372B (+0.00%)
Details
travis-ci/tools-py2.7 Local tools-py2.7 testing has passed
Details

@tkem tkem deleted the tkem:fix/remove-unnnecessary-includes branch Aug 28, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment