New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lora: Remove duplicate LinkCheckReq MAC command #7895

Merged
merged 1 commit into from Sep 3, 2018

Conversation

Projects
None yet
6 participants
@kivaisan
Contributor

kivaisan commented Aug 27, 2018

Description

When application requests link check request with add_link_check_request()
it was added to MAC command buffer. Again when actual TX was started,
stack cherry-picked the request into MAC buffer again resulting in a duplicate
entry in the buffer.

Functionality is changed now so that add_link_check_request() does not add
the request into MAC command buffer but it is cherry-picked into the buffer when
TX is issued.

Pull request type

[X] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Breaking change
Lora: Remove duplicate LinkCheckReq MAC command
When application requests link check request with add_link_check_request()
it was added to MAC command buffer. Again when actual TX was started,
stack cherry-picked the request into MAC buffer again resulting in a duplicate
entry in the buffer.

Functionality is changed now so that add_link_check_request() does not add
the request into MAC command buffer but it is cherry-picked into the buffer when
TX is issued.
@kivaisan

This comment has been minimized.

Contributor

kivaisan commented Aug 27, 2018

@AnttiKauppila @hasnainvirk please review.

@0xc0170 0xc0170 requested a review from ARMmbed/mbed-os-wan Aug 27, 2018

@0xc0170 0xc0170 added needs: CI and removed needs: review labels Aug 28, 2018

@AnttiKauppila

This comment has been minimized.

Contributor

AnttiKauppila commented Sep 2, 2018

This is targeted to 5.10.0-rc2

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Sep 3, 2018

/morph build

@mbed-ci

This comment has been minimized.

mbed-ci commented Sep 3, 2018

Build : SUCCESS

Build number : 2994
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/7895/

Triggering tests

/morph test
/morph export-build
/morph mbed2-build

@mbed-ci

This comment has been minimized.

@mbed-ci

This comment has been minimized.

@adbridge adbridge merged commit 4fb3aec into ARMmbed:master Sep 3, 2018

14 checks passed

ci-morph-build build completed
Details
ci-morph-exporter build completed
Details
ci-morph-mbed2-build build completed
Details
ci-morph-test test completed , RTOS ROM(+0.0%) RAM(-0.12%)
Details
continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
jenkins-ci/cloud_client_smoke_test Test job was successful
Details
travis-ci/astyle Passed, 553 files
Details
travis-ci/docs Local docs testing has passed
Details
travis-ci/events Passed, runtime is 10255 cycles (+1105 cycles)
Details
travis-ci/gitattributestest Local gitattributestest testing has passed
Details
travis-ci/licence_check Local licence_check testing has passed
Details
travis-ci/littlefs Passed, code size is 8372B (+0.00%)
Details
travis-ci/tools-py2.7 Local tools-py2.7 testing has passed
Details

@0xc0170 0xc0170 removed the needs: CI label Sep 3, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment