New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix pin names of MIMXRT1050 I2C pins #7896

Merged
merged 2 commits into from Oct 1, 2018

Conversation

Projects
None yet
6 participants
@alrodlim
Contributor

alrodlim commented Aug 27, 2018

Description

Fixed the I2C pin mappings of MIMXRT1050 to the correct I/O pads.

Pull request type

[x] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Breaking change

@0xc0170 0xc0170 requested a review from mmahadevan108 Aug 27, 2018

@0xc0170 0xc0170 changed the title from fixed pin names of MIMXRT1050 I2C pins to Fix pin names of MIMXRT1050 I2C pins Sep 20, 2018

@0xc0170 0xc0170 added needs: CI and removed needs: review labels Sep 20, 2018

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Sep 24, 2018

/morph build

@mbed-ci

This comment has been minimized.

mbed-ci commented Sep 24, 2018

@0xc0170 0xc0170 added needs: work and removed needs: CI labels Sep 24, 2018

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Sep 24, 2018

Please review the failure (those pins used should be first defined)

@alrodlim

This comment has been minimized.

Contributor

alrodlim commented Sep 24, 2018

I have fixed the problem by moving the I2C pins definitions after A4 and A5 are defined.

@0xc0170 0xc0170 added needs: CI and removed needs: work labels Sep 24, 2018

@cmonr

This comment has been minimized.

Contributor

cmonr commented Sep 24, 2018

@alrodlim The unit test are a new addition. The failure is being fixed in another PR, and doesn't appear to be caused by this PR.

@unsignedint

This comment has been minimized.

unsignedint commented Sep 27, 2018

Just FYI, I noticed the same issue with this target.. this fix LGTM 👍

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Sep 27, 2018

/morph build

@mbed-ci

This comment has been minimized.

mbed-ci commented Sep 27, 2018

Build : SUCCESS

Build number : 3178
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/7896/

Triggering tests

/morph test
/morph export-build
/morph mbed2-build

@mbed-ci

This comment has been minimized.

@cmonr

This comment has been minimized.

Contributor

cmonr commented Sep 27, 2018

/morph mbed2-build

@mbed-ci

This comment has been minimized.

@cmonr

This comment has been minimized.

Contributor

cmonr commented Sep 29, 2018

/morph mbed2-build

@cmonr cmonr added ready for merge and removed needs: CI labels Sep 29, 2018

@0xc0170 0xc0170 merged commit b1011bf into ARMmbed:master Oct 1, 2018

15 checks passed

ci-morph-build build completed
Details
ci-morph-exporter build completed
Details
ci-morph-mbed2-build build completed
Details
ci-morph-test test completed , RTOS ROM(+0.0%) RAM(+0.0%)
Details
continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
jenkins-ci/cloud_client_smoke_test Success
Details
jenkins-ci/unittests Success
Details
travis-ci/astyle Passed, 612 files
Details
travis-ci/docs Local docs testing has passed
Details
travis-ci/events Passed, runtime is 9153 cycles (+101 cycles)
Details
travis-ci/gitattributestest Local gitattributestest testing has passed
Details
travis-ci/licence_check Local licence_check testing has passed
Details
travis-ci/littlefs Passed, code size is 8372B (+0.00%)
Details
travis-ci/tools-py2.7 Local tools-py2.7 testing has passed
Details

@0xc0170 0xc0170 removed the ready for merge label Oct 1, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment