New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Travis: fix astyle report (-/+ files) #7898

Merged
merged 1 commit into from Oct 10, 2018

Conversation

Projects
None yet
5 participants
@0xc0170
Member

0xc0170 commented Aug 27, 2018

Description

Touching few files from various area, the changes are minimal.

Test for #7897 (to confirm this is the issue currently, recent PR shows only numbers so either the number has not changed or not working). This is important to make working , no more + number in the PR 馃憤

Pull request type

[X] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Breaking change

@0xc0170 0xc0170 changed the title from Fix astyle common to Fix coding style in platform/drivers/rtos Aug 27, 2018

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Aug 27, 2018

AStyle only reports the total number (should be - few files).

Master reports 553 files, here we got 529 files so negative number should be reported here

@0xc0170 0xc0170 requested a review from geky Aug 27, 2018

@0xc0170 0xc0170 force-pushed the 0xc0170:fix_astyle_common branch 2 times, most recently from 1b3987d to 88751a8 Aug 27, 2018

@0xc0170 0xc0170 added needs: work and removed needs: review labels Aug 27, 2018

@0xc0170 0xc0170 force-pushed the 0xc0170:fix_astyle_common branch from 88751a8 to 6ece6aa Aug 27, 2018

@0xc0170 0xc0170 force-pushed the 0xc0170:fix_astyle_common branch 3 times, most recently from 45ac626 to a4065cb Aug 27, 2018

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Aug 29, 2018

Looks like Travis astyle report is fixed Passed, 531 files (-24 files)

@0xc0170 0xc0170 added needs: review and removed needs: work labels Aug 29, 2018

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Aug 29, 2018

Ready for reviews !

@geky

geky approved these changes Aug 30, 2018

Good catches in the astyle script 馃憤

@0xc0170 0xc0170 added needs: work and removed needs: review labels Sep 20, 2018

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Sep 20, 2018

Will rebase after 5.10.1, and update it

@0xc0170 0xc0170 force-pushed the 0xc0170:fix_astyle_common branch from a4065cb to f1f16e5 Oct 9, 2018

@0xc0170 0xc0170 changed the title from Fix coding style in platform/drivers/rtos to Travis: fix astyle report (-/+ files) Oct 9, 2018

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Oct 9, 2018

Rescoped this PR. It now only fixes Travis AStyle report. I'll send the files separately in another PR

@cmonr Please review

@cmonr

cmonr approved these changes Oct 9, 2018

@0xc0170 0xc0170 added needs: CI and removed needs: review labels Oct 9, 2018

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Oct 9, 2018

/morph build

@mbed-ci

This comment has been minimized.

mbed-ci commented Oct 9, 2018

Build : SUCCESS

Build number : 3300
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/7898/

Triggering tests

/morph test
/morph export-build
/morph mbed2-build

@cmonr

This comment has been minimized.

Contributor

cmonr commented Oct 9, 2018

ci-morph-mbed2-build failed because the ARM license server is down.

xD

嗖燺嗖

@cmonr

This comment has been minimized.

Contributor

cmonr commented Oct 9, 2018

Arm License network issues, now fixed.
Relaunching.

/morph export-build

@cmonr

This comment has been minimized.

Contributor

cmonr commented Oct 9, 2018

/morph mbed2-build

@mbed-ci

This comment has been minimized.

@mbed-ci

This comment has been minimized.

@cmonr cmonr merged commit dc4a52c into ARMmbed:master Oct 10, 2018

15 checks passed

ci-morph-build build completed
Details
ci-morph-exporter build completed
Details
ci-morph-mbed2-build build completed
Details
ci-morph-test test completed
Details
continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
jenkins-ci/cloud-client-test Success
Details
jenkins-ci/unittests Success
Details
travis-ci/astyle Passed, 653 files (+0 files)
Details
travis-ci/docs Local docs testing has passed
Details
travis-ci/events Passed, runtime is 9928 cycles (-396 cycles)
Details
travis-ci/gitattributestest Local gitattributestest testing has passed
Details
travis-ci/licence_check Local licence_check testing has passed
Details
travis-ci/littlefs Passed, code size is 8372B (+0.00%)
Details
travis-ci/tools-py2.7 Local tools-py2.7 testing has passed
Details

@cmonr cmonr removed the ready for merge label Oct 10, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment