New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bluetooth 5 Phy support #7899

Merged
merged 14 commits into from Aug 31, 2018

Conversation

Projects
None yet
5 participants
@pan-
Member

pan- commented Aug 27, 2018

Description

Add support to update the phy used during a connection.

This PR is the results of our work in our private repo (it has already been reviewed internally); it requires #7869 to go in first as it includes an old version of the precompiled cordio stack.

PR:

  • API definition: 1, 2
  • Nordic implementation: 1
  • Cordio implementation 1, 2, 3

Pull request type

[ ] Fix
[ ] Refactor
[ ] Target update
[X] Functionality change
[ ] Breaking change

@0xc0170 0xc0170 requested review from ARMmbed/mbed-os-connectivity and removed request for ARMmbed/mbed-os-connectivity Aug 27, 2018

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Aug 27, 2018

@ARMmbed/mbed-os-pan Please review (I cant assign you as reviewers, will fix that).

@pan- pan- force-pushed the pan-:bt-phy branch 2 times, most recently from 1180ce7 to 064898e Aug 29, 2018

@pan- pan- force-pushed the pan-:bt-phy branch from 064898e to db3d124 Aug 29, 2018

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Aug 30, 2018

@donatieng The target release for this one? Not yet specified anywhere. As it is adding new functionality, it can be either 5.10 or 5.11 at the moment.

@donatieng

This comment has been minimized.

Member

donatieng commented Aug 30, 2018

Hi @0xc0170, this one is indeed meant for 5.10 - it's ready for CI.

@0xc0170 0xc0170 added needs: CI and removed needs: review labels Aug 30, 2018

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Aug 30, 2018

/morph build

@mbed-ci

This comment has been minimized.

mbed-ci commented Aug 30, 2018

Build : SUCCESS

Build number : 2966
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/7899/

Triggering tests

/morph test
/morph export-build
/morph mbed2-build

@mbed-ci

This comment has been minimized.

@mbed-ci

This comment has been minimized.

@0xc0170 0xc0170 added ready for merge and removed needs: CI labels Aug 31, 2018

@0xc0170 0xc0170 merged commit 2e869df into ARMmbed:master Aug 31, 2018

14 checks passed

ci-morph-build build completed
Details
ci-morph-exporter build completed
Details
ci-morph-mbed2-build build completed
Details
ci-morph-test test completed , RTOS ROM(+0.0%) RAM(-0.12%)
Details
continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
jenkins-ci/cloud_client_smoke_test Test job: successful
Details
travis-ci/astyle Passed, 558 files
Details
travis-ci/docs Local docs testing has passed
Details
travis-ci/events Passed, runtime is 9898 cycles (+42 cycles)
Details
travis-ci/gitattributestest Local gitattributestest testing has passed
Details
travis-ci/licence_check Local licence_check testing has passed
Details
travis-ci/littlefs Passed, code size is 8372B (+0.00%)
Details
travis-ci/tools-py2.7 Local tools-py2.7 testing has passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment