New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Support for Toshiba TMPM4G9 #7923

Merged
merged 3 commits into from Oct 16, 2018

Conversation

Projects
None yet
6 participants
@ganesh-ramachandran
Contributor

ganesh-ramachandran commented Aug 29, 2018

Description

Add mbed support for TOSHIBA's TMPM4G9 board.

Tested with all toolchains and test results are attached.
M4G9_GreenteaAutomated_TestResults.txt
M4G9_SingleAutomated_TestResults.txt

Pull request type

[ ] Fix
[ ] Refactor
[x] New target
[ ] Feature
[ ] Breaking change
@ganesh-ramachandran

This comment has been minimized.

Contributor

ganesh-ramachandran commented Aug 31, 2018

Rebased

@ganesh-ramachandran

This comment has been minimized.

Contributor

ganesh-ramachandran commented Sep 17, 2018

Hi @0xc0170, any status update on this PR.

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Sep 17, 2018

Hi @0xc0170, any status update on this PR.

I'll review it today

NVIC_ClearPendingIRQ(INTT32A00_A_CT_IRQn);
}
void us_ticker_free(void)

This comment has been minimized.

@0xc0170

0xc0170 Sep 18, 2018

Member

why this function is empty?

This comment has been minimized.

@ganesh-ramachandran

ganesh-ramachandran Sep 18, 2018

Contributor

For successful compilation added this function body. However implemented the function now.

define symbol __ICFEDIT_region_BRAM_end__ = 0x200307FF;
/*-Sizes-*/
/*Heap 1/4 of ram and stack 1/8*/
define symbol __ICFEDIT_size_cstack__ = 0xC000;

This comment has been minimized.

@0xc0170

0xc0170 Sep 18, 2018

Member

1k stack size

This comment has been minimized.

@ganesh-ramachandran

ganesh-ramachandran Sep 18, 2018

Contributor

We have changed the stack size to 1K.

@0xc0170 0xc0170 added needs: CI and removed needs: review labels Sep 20, 2018

@cmonr

This comment has been minimized.

Contributor

cmonr commented Sep 23, 2018

/morph build

@mbed-ci

This comment has been minimized.

mbed-ci commented Sep 23, 2018

Build : SUCCESS

Build number : 3141
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/7923/

Triggering tests

/morph test
/morph export-build
/morph mbed2-build

@mbed-ci

This comment has been minimized.

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Sep 24, 2018

@ganesh-ramachandran Can you review the 2 failures ? What IAR version is required? This requires a new cmsis pack, will request the update (uvision failure)

@0xc0170 0xc0170 added needs: work and removed needs: CI labels Sep 24, 2018

@mbed-ci

This comment has been minimized.

@ganesh-ramachandran

This comment has been minimized.

Contributor

ganesh-ramachandran commented Sep 24, 2018

Can you review the 2 failures ? What IAR version is required? This requires a new cmsis pack, will request the update (uvision failure)

@0xc0170, for IAR - issue is due to IAR version. Issue occurs in IAR V7.5... We are working with IAR 7.8... and no issues with that. For uvision failure - M4G9 keil pack to be installed (http://www.keil.com/dd2/toshiba/tmpm4g9f15fg/)

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Sep 24, 2018

The pack update was requested to be added (will be in couple of days). The IAR should be 7.8 for exporters, I noticed the build utility reportes 7.5.

@OPpuolitaival @studavekar What is the IAR version used by exporters?

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Oct 9, 2018

@ganesh-ramachandran Can you rebase? I would like to restart testing (we updated cmsis packs for uvision, need to check if this MCU is also in or will need to request one).

Sorry for the delay, there were various CI challenges in the last 2 weeks

@ganesh-ramachandran

This comment has been minimized.

Contributor

ganesh-ramachandran commented Oct 10, 2018

@ganesh-ramachandran Can you rebase? I would like to restart testing (we updated cmsis packs for uvision, need to check if this MCU is also in or will need to request one).

Sorry for the delay, there were various CI challenges in the last 2 weeks

@0xc0170, Rebased. Thank you for the confirmation on cmsis packs for uvision. IAR exporter version is also fixed?

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Oct 10, 2018

/morph export-build

@0xc0170 0xc0170 added needs: CI and removed needs: work labels Oct 10, 2018

@mbed-ci

This comment has been minimized.

@cmonr

This comment has been minimized.

Contributor

cmonr commented Oct 11, 2018

@ganesh-ramachandran Could you refer us to the IAR 7.x release notes where the device was added?

We were able to find this, but it's for 8.30: http://supp.iar.com/FilesPublic/UPDINFO/013240/arm/doc/infocenter/readme.ENU.html

@cmonr cmonr added needs: work and removed needs: CI labels Oct 11, 2018

@ganesh-ramachandran

This comment has been minimized.

Contributor

ganesh-ramachandran commented Oct 12, 2018

@ganesh-ramachandran Could you refer us to the IAR 7.x release notes where the device was added?

We were able to find this, but it's for 8.30:

@cmonr Yes, TMPM4G9 is added in IAR 8.30, We have compiled and tested using mbed-cli with IAR 7.8. May be exporter build might succeed with IAR 7.8. Or when IAR 8.30 would be effective.

@adbridge

This comment has been minimized.

Contributor

adbridge commented Oct 12, 2018

/morph build

@mbed-ci

This comment has been minimized.

mbed-ci commented Oct 12, 2018

Build : SUCCESS

Build number : 3336
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/7923/

Triggering tests

/morph test
/morph export-build
/morph mbed2-build

@mbed-ci

This comment has been minimized.

@mbed-ci

This comment has been minimized.

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Oct 12, 2018

@cmonr Yes, TMPM4G9 is added in IAR 8.30, We have compiled and tested using mbed-cli with IAR 7.8. May be exporter build might succeed with IAR 7.8. Or when IAR 8.30 would be effective.

Based on this, exporters should be disabled for now (not supported in 7.x version), please remove iar definition.

We requested cmsis pack update in the CI to get exporters green

@cmonr

This comment has been minimized.

Contributor

cmonr commented Oct 12, 2018

Whoops. Jumped the gun again on restarting the export job.

Iar network license issue with mbed2 build
/morph mbed2-build

Ganesh Ramachandran added some commits Aug 29, 2018

Ganesh Ramachandran Ganesh Ramachandran
Removed IAR definition for TMPM4G9
TMPM4G9 device was added in IAR 8.30. Based on this, exporters should be disabled for now (not supported in 7.x version).
@ganesh-ramachandran

This comment has been minimized.

Contributor

ganesh-ramachandran commented Oct 15, 2018

Based on this, exporters should be disabled for now (not supported in 7.x version), please remove iar definition.

We requested cmsis pack update in the CI to get exporters green

@0xc0170 Removed IAR definition. Requesting to start CI tests again.

@NirSonnenschein

This comment has been minimized.

Contributor

NirSonnenschein commented Oct 15, 2018

/morph build

@mbed-ci

This comment has been minimized.

mbed-ci commented Oct 15, 2018

Build : SUCCESS

Build number : 3355
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/7923/

Triggering tests

/morph test
/morph export-build
/morph mbed2-build

@mbed-ci

This comment has been minimized.

@mbed-ci

This comment has been minimized.

@NirSonnenschein

This comment has been minimized.

Contributor

NirSonnenschein commented Oct 15, 2018

failures seem to be iar license related:
/morph export-build
/morph mbed2-build

@mbed-ci

This comment has been minimized.

@ganesh-ramachandran

This comment has been minimized.

Contributor

ganesh-ramachandran commented Oct 15, 2018

d like to restart testing (we updated cmsis packs for uvision, need to check if this MCU is also in or will need to request one).

cmsis pack for uvision to be updated to add this MCU (https://www.keil.com/dd2/toshiba/tmpm4g9f15fg/).
Requesting to update this pack to fix the uvision exporter build failure for TMPM4G9.

@cmonr

This comment has been minimized.

Contributor

cmonr commented Oct 15, 2018

@ganesh-ramachandran Correct. We still have an internal ticket open to add it into our expoter VM seeds.

@cmonr

This comment has been minimized.

Contributor

cmonr commented Oct 16, 2018

Should be ready now!

/morph export-build

@mbed-ci

This comment has been minimized.

@cmonr cmonr merged commit af19a39 into ARMmbed:master Oct 16, 2018

15 checks passed

ci-morph-build build completed
Details
ci-morph-exporter build completed
Details
ci-morph-mbed2-build build completed
Details
ci-morph-test test completed , RTOS ROM(+0 bytes) RAM(+0 bytes)
Details
continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
jenkins-ci/cloud-client-test Success
Details
jenkins-ci/unittests Success
Details
travis-ci/astyle Passed, 658 files (+0 files)
Details
travis-ci/docs Local docs testing has passed
Details
travis-ci/events Passed, runtime is 9977 cycles (+39 cycles)
Details
travis-ci/gitattributestest Local gitattributestest testing has passed
Details
travis-ci/licence_check Local licence_check testing has passed
Details
travis-ci/littlefs Passed, code size is 8372B (+0.00%)
Details
travis-ci/tools-py2.7 Local tools-py2.7 testing has passed
Details

@cmonr cmonr removed the needs: CI label Oct 16, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment